Re: [U-Boot] [U-boot] [Patch] dma: keystone_nav: remove spurious qm_cfg verification

2014-11-04 Thread Tom Rini
On Tue, Nov 04, 2014 at 01:39:27AM +0200, Ivan Khoronzhuk wrote:

 The verification qm_cfg existence is done at ksnav_init().
 So, there is no need to verify it after initialization.
 
 Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@ti.com

Reviewed-by: Tom Rini tr...@ti.com

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [U-boot] [Patch] dma: keystone_nav: remove spurious qm_cfg verification

2014-11-03 Thread Ivan Khoronzhuk
The verification qm_cfg existence is done at ksnav_init().
So, there is no need to verify it after initialization.

Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@ti.com
---
 drivers/dma/keystone_nav.c | 12 
 1 file changed, 12 deletions(-)

diff --git a/drivers/dma/keystone_nav.c b/drivers/dma/keystone_nav.c
index 77707c2..dfca75a 100644
--- a/drivers/dma/keystone_nav.c
+++ b/drivers/dma/keystone_nav.c
@@ -81,9 +81,6 @@ void qm_close(void)
 {
u32 j;
 
-   if (qm_cfg == NULL)
-   return;
-
queue_close(qm_cfg-qpool_num);
 
qm_cfg-mngr_cfg-link_ram_base0= 0;
@@ -105,9 +102,6 @@ void qm_push(struct qm_host_desc *hd, u32 qnum)
 {
u32 regd;
 
-   if (!qm_cfg)
-   return;
-
cpu_to_bus((u32 *)hd, sizeof(struct qm_host_desc)/4);
regd = (u32)hd | ((sizeof(struct qm_host_desc)  4) - 1);
writel(regd, qm_cfg-queue[qnum].ptr_size_thresh);
@@ -127,9 +121,6 @@ struct qm_host_desc *qm_pop(u32 qnum)
 {
u32 uhd;
 
-   if (!qm_cfg)
-   return NULL;
-
uhd = readl(qm_cfg-queue[qnum].ptr_size_thresh)  ~0xf;
if (uhd)
cpu_to_bus((u32 *)uhd, sizeof(struct qm_host_desc)/4);
@@ -139,9 +130,6 @@ struct qm_host_desc *qm_pop(u32 qnum)
 
 struct qm_host_desc *qm_pop_from_free_pool(void)
 {
-   if (!qm_cfg)
-   return NULL;
-
return qm_pop(qm_cfg-qpool_num);
 }
 
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot