Re: [U-Boot] [PATCH] usb: sunxi: don't touch reset bits in ccm if CONFIG_SUNXI_GEN_SUN6I is not defined

2018-06-13 Thread Jagan Teki
On Thu, Jun 14, 2018 at 11:06 AM, Vasily Khoruzhick wrote: > On Wed, Jun 13, 2018 at 10:29 PM, Jagan Teki wrote: >> On Thu, Jun 14, 2018 at 9:01 AM, Vasily Khoruzhick >> wrote: >>> On Wed, Jun 13, 2018 at 8:23 PM, Chen-Yu Tsai wrote: >>> > + if (priv->cfg->has_reset) { > +#ifdef

Re: [U-Boot] [PATCH] usb: sunxi: don't touch reset bits in ccm if CONFIG_SUNXI_GEN_SUN6I is not defined

2018-06-13 Thread Vasily Khoruzhick
On Wed, Jun 13, 2018 at 10:29 PM, Jagan Teki wrote: > On Thu, Jun 14, 2018 at 9:01 AM, Vasily Khoruzhick wrote: >> On Wed, Jun 13, 2018 at 8:23 PM, Chen-Yu Tsai wrote: >> + if (priv->cfg->has_reset) { +#ifdef CONFIG_SUNXI_GEN_SUN6I >>> >>> The "has_reset" field is supposed to

Re: [U-Boot] [PATCH] usb: sunxi: don't touch reset bits in ccm if CONFIG_SUNXI_GEN_SUN6I is not defined

2018-06-13 Thread Jagan Teki
On Thu, Jun 14, 2018 at 9:01 AM, Vasily Khoruzhick wrote: > On Wed, Jun 13, 2018 at 8:23 PM, Chen-Yu Tsai wrote: > >>> + if (priv->cfg->has_reset) { >>> +#ifdef CONFIG_SUNXI_GEN_SUN6I >> >> The "has_reset" field is supposed to deal with this. Is it not working? > > There's no

Re: [U-Boot] [PATCH] usb: sunxi: don't touch reset bits in ccm if CONFIG_SUNXI_GEN_SUN6I is not defined

2018-06-13 Thread Vasily Khoruzhick
On Wed, Jun 13, 2018 at 8:23 PM, Chen-Yu Tsai wrote: >> + if (priv->cfg->has_reset) { >> +#ifdef CONFIG_SUNXI_GEN_SUN6I > > The "has_reset" field is supposed to deal with this. Is it not working? There's no ahb_reset0_cfg in ccm on sun4i and sun5i, so compilation fails with

Re: [U-Boot] [PATCH] usb: sunxi: don't touch reset bits in ccm if CONFIG_SUNXI_GEN_SUN6I is not defined

2018-06-13 Thread Chen-Yu Tsai
On Thu, Jun 14, 2018 at 11:04 AM, Vasily Khoruzhick wrote: > CCM in sun4i and sun5i doesn't have reset. > > Fixes commit 1ed9c1118 ("usb: sunxi: ehci: get rid of ifdefs") > and commit 56830cee3 ("usb: sunxi: ohci: get rid of ifdefs") > > Signed-off-by: Vasily Khoruzhick > --- >