Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-13 Thread Stefano Babic
On 12/03/2018 21:51, Fabio Estevam wrote: > Hi Tom and Stefano, > > On Mon, Mar 12, 2018 at 1:07 PM, Tom Rini wrote: > >>> Anyway, I am facing what we should do with this patch for 2018.03. As I >>> said, I am not forcing anyone and I have just picked up 1/3 and 2/3. But >>>

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-12 Thread Fabio Estevam
On Fri, Mar 9, 2018 at 10:07 AM, Bryan O'Donoghue wrote: > commit 8c4037a09a5c ("imx: hab: Ensure the IVT DCD pointer is Null prior > to calling HAB authenticate function.") makes the DCD field being NULL a > dependency. > > This change though will break loading and

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-12 Thread Fabio Estevam
Hi Tom and Stefano, On Mon, Mar 12, 2018 at 1:07 PM, Tom Rini wrote: >> Anyway, I am facing what we should do with this patch for 2018.03. As I >> said, I am not forcing anyone and I have just picked up 1/3 and 2/3. But >> IMHO, if there are not good reason to say that not

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-12 Thread Bryan O'Donoghue
On 12/03/18 16:33, Breno Matheus Lima wrote: The purpose of hab_rvt_authenticate_image() API function is to authenticate additional boot images in a post-ROM stage, initial boot images are supposed to be authenticate only once by the initial ROM code. The HAB implementation in older devices

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-12 Thread Breno Matheus Lima
Hi All, 2018-03-12 13:07 GMT-03:00 Tom Rini : > On Sun, Mar 11, 2018 at 03:36:16PM +0100, Stefano Babic wrote: >> Hi Everybody, >> >> I have applied 1-2 as Fabio suggested. I have a couple of comments for >> this, too: >> >> On 10/03/2018 02:10, Breno Matheus Lima wrote: >> >

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-12 Thread Tom Rini
On Sun, Mar 11, 2018 at 03:36:16PM +0100, Stefano Babic wrote: > Hi Everybody, > > I have applied 1-2 as Fabio suggested. I have a couple of comments for > this, too: > > On 10/03/2018 02:10, Breno Matheus Lima wrote: > > Hi Bryan, > > > > 2018-03-09 10:07 GMT-03:00 Bryan O'Donoghue

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-12 Thread Bryan O'Donoghue
On 10/03/18 01:10, Breno Matheus Lima wrote: Hi Bryan, 2018-03-09 10:07 GMT-03:00 Bryan O'Donoghue : commit 8c4037a09a5c ("imx: hab: Ensure the IVT DCD pointer is Null prior to calling HAB authenticate function.") makes the DCD field being NULL a dependency. This

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-11 Thread Stefano Babic
Hi Everybody, I have applied 1-2 as Fabio suggested. I have a couple of comments for this, too: On 10/03/2018 02:10, Breno Matheus Lima wrote: > Hi Bryan, > > 2018-03-09 10:07 GMT-03:00 Bryan O'Donoghue : >> commit 8c4037a09a5c ("imx: hab: Ensure the IVT DCD pointer

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-09 Thread Breno Matheus Lima
Hi Bryan, 2018-03-09 10:07 GMT-03:00 Bryan O'Donoghue : > commit 8c4037a09a5c ("imx: hab: Ensure the IVT DCD pointer is Null prior > to calling HAB authenticate function.") makes the DCD field being NULL a > dependency. > > This change though will break loading and

Re: [U-Boot] [PATCH 3/3] imx: hab: Convert DCD non-NULL error to warning

2018-03-09 Thread Fabio Estevam
Hi Bryan, On Fri, Mar 9, 2018 at 10:07 AM, Bryan O'Donoghue wrote: > commit 8c4037a09a5c ("imx: hab: Ensure the IVT DCD pointer is Null prior > to calling HAB authenticate function.") makes the DCD field being NULL a > dependency. > > This change though will break