Re: [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support

[Keerthy]

On Monday 19 September 2016 06:28 AM, Simon Glass wrote:

On 13 September 2016 at 22:28, Keerthy  wrote:

The driver provides regulator set/get voltage
enable/disable functions for palmas family of PMICs.

Signed-off-by: Keerthy 
---
 drivers/power/regulator/Kconfig|   8 +
 drivers/power/regulator/Makefile   |   1 +
 drivers/power/regulator/palmas_regulator.c | 460 +
 3 files changed, 469 insertions(+)
 create mode 100644 drivers/power/regulator/palmas_regulator.c


Reviewed-by: Simon Glass 

But please consider using dm_i2c_reg_read()

Also you have two blank lines at one point.


Sure i will fix them and repost.
Thanks for the review.




___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support

[Simon Glass]

On 13 September 2016 at 22:28, Keerthy  wrote:
> The driver provides regulator set/get voltage
> enable/disable functions for palmas family of PMICs.
>
> Signed-off-by: Keerthy 
> ---
>  drivers/power/regulator/Kconfig|   8 +
>  drivers/power/regulator/Makefile   |   1 +
>  drivers/power/regulator/palmas_regulator.c | 460 
> +
>  3 files changed, 469 insertions(+)
>  create mode 100644 drivers/power/regulator/palmas_regulator.c

Reviewed-by: Simon Glass 

But please consider using dm_i2c_reg_read()

Also you have two blank lines at one point.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot