Re: [U-Boot] [PATCH v2 02/17] serial: Kconfig: Add MXC_UART entry

[Jagan Teki]

Hi Peng,

On Mon, Sep 19, 2016 at 11:23 AM, Peng Fan  wrote:
> Hi Jagan,
> On Sat, Sep 17, 2016 at 02:18:34AM +0530, Jagan Teki wrote:
>>Added kconfig for MXC_UART driver.
>>
>>Cc: Simon Glass 
>>Cc: Fabio Estevam 
>>Cc: Stefano Babic 
>>Cc: Peng Fan 
>>Cc: Matteo Lisi 
>>Cc: Michael Trimarchi 
>>Signed-off-by: Jagan Teki 
>>---
>> drivers/serial/Kconfig | 7 +++
>> 1 file changed, 7 insertions(+)
>>
>>diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
>>index ab5df70..9abf158 100644
>>--- a/drivers/serial/Kconfig
>>+++ b/drivers/serial/Kconfig
>>@@ -295,6 +295,13 @@ config FSL_LPUART
>> Select this to enable a Low Power UART for Freescale VF610 and
>> QorIQ Layerscape devices.
>>
>>+config MXC_UART
>>+  bool "IMX serial port support"
>>+  depends on MX6
>
> Not only MX6. I think this line could be removed.
> Add "selects MXC_UART" in arch/arm/cpu/armv7/mx6/Kconfig or just add 
> "CONFIG_MXC_UART"
> in defconfig.

It's not a better approach to select driver config, since it's in
drivers/ directory and any new user will looking in to into it for
config entry to select and proper help text to understand better.

The reason I've added MX6 is my defconfig entries are tested for MX6
arch related if some wanted this driver config in their defconfig and
with MX7 or something they simply update the 'depends on'

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 02/17] serial: Kconfig: Add MXC_UART entry

[Peng Fan]

Hi Jagan,
On Sat, Sep 17, 2016 at 02:18:34AM +0530, Jagan Teki wrote:
>Added kconfig for MXC_UART driver.
>
>Cc: Simon Glass 
>Cc: Fabio Estevam 
>Cc: Stefano Babic 
>Cc: Peng Fan 
>Cc: Matteo Lisi 
>Cc: Michael Trimarchi 
>Signed-off-by: Jagan Teki 
>---
> drivers/serial/Kconfig | 7 +++
> 1 file changed, 7 insertions(+)
>
>diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
>index ab5df70..9abf158 100644
>--- a/drivers/serial/Kconfig
>+++ b/drivers/serial/Kconfig
>@@ -295,6 +295,13 @@ config FSL_LPUART
> Select this to enable a Low Power UART for Freescale VF610 and
> QorIQ Layerscape devices.
> 
>+config MXC_UART
>+  bool "IMX serial port support"
>+  depends on MX6

Not only MX6. I think this line could be removed. 
Add "selects MXC_UART" in arch/arm/cpu/armv7/mx6/Kconfig or just add 
"CONFIG_MXC_UART"
in defconfig.

Regards,
Peng.

>+  help
>+If you have a machine based on a Motorola IMX CPU you
>+can enable its onboard serial port by enabling this option.
>+
> config PIC32_SERIAL
>   bool "Support for Microchip PIC32 on-chip UART"
>   depends on DM_SERIAL && MACH_PIC32
>-- 
>2.7.4
>
>___
>U-Boot mailing list
>U-Boot@lists.denx.de
>http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot