[PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-20 Thread xiaobo
From: Alexandru Gagniuc This reverts commit 38d6b7ebdaee3e0e8426ef1b9df88bdce8ae2e75. struct global_data contains a pointer to the bd_info structure. This pointer was populated spl_set_bd() to a pre-allocated bd_info in the ".data" section. The referenced commit replaced this mechanism to one

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-19 Thread Tom Rini
On Thu, Apr 08, 2021 at 11:56:11AM -0500, Alexandru Gagniuc wrote: > This reverts commit 38d6b7ebdaee3e0e8426ef1b9df88bdce8ae2e75. > > struct global_data contains a pointer to the bd_info structure. This > pointer was populated spl_set_bd() to a pre-allocated bd_info in the > ".data" section.

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-19 Thread Tom Rini
On Tue, Apr 13, 2021 at 05:49:19AM +1200, Simon Glass wrote: > Hi Tom, Alex, > > On Tue, 13 Apr 2021 at 04:26, Tom Rini wrote: > > > > On Mon, Apr 12, 2021 at 10:21:18AM -0500, Alex G. wrote: > > > > > > > > > On 4/12/21 9:40 AM, Tom Rini wrote: > > > > On Mon, Apr 12, 2021 at 08:51:11AM -0500,

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-18 Thread Alex G.
On 4/16/21 6:16 PM, Adam Ford wrote: On Fri, Apr 16, 2021 at 3:41 PM Tim Harvey wrote: On Mon, Apr 12, 2021 at 11:44 AM Simon Glass wrote: Hi Tom, On Tue, 13 Apr 2021 at 06:38, Tom Rini wrote: On Tue, Apr 13, 2021 at 06:26:08AM +1200, Simon Glass wrote: Hi Tom, On Tue, 13 Apr 2021 at

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-16 Thread Adam Ford
On Fri, Apr 16, 2021 at 3:41 PM Tim Harvey wrote: > > On Mon, Apr 12, 2021 at 11:44 AM Simon Glass wrote: > > > > Hi Tom, > > > > On Tue, 13 Apr 2021 at 06:38, Tom Rini wrote: > > > > > > On Tue, Apr 13, 2021 at 06:26:08AM +1200, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue, 13 Apr

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-16 Thread Tim Harvey
On Mon, Apr 12, 2021 at 11:44 AM Simon Glass wrote: > > Hi Tom, > > On Tue, 13 Apr 2021 at 06:38, Tom Rini wrote: > > > > On Tue, Apr 13, 2021 at 06:26:08AM +1200, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 13 Apr 2021 at 06:18, Tom Rini wrote: > > > > > > > > On Tue, Apr 13, 2021 at

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Simon Glass
Hi Tom, On Tue, 13 Apr 2021 at 06:38, Tom Rini wrote: > > On Tue, Apr 13, 2021 at 06:26:08AM +1200, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 13 Apr 2021 at 06:18, Tom Rini wrote: > > > > > > On Tue, Apr 13, 2021 at 05:49:19AM +1200, Simon Glass wrote: > [snip] > > > > As to a weak

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Tom Rini
On Tue, Apr 13, 2021 at 06:26:08AM +1200, Simon Glass wrote: > Hi Tom, > > On Tue, 13 Apr 2021 at 06:18, Tom Rini wrote: > > > > On Tue, Apr 13, 2021 at 05:49:19AM +1200, Simon Glass wrote: [snip] > > > As to a weak function, what would the default behaviour be? If we can > > > define that, then

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Simon Glass
Hi Tom, On Tue, 13 Apr 2021 at 06:18, Tom Rini wrote: > > On Tue, Apr 13, 2021 at 05:49:19AM +1200, Simon Glass wrote: > > Hi Tom, Alex, > > > > On Tue, 13 Apr 2021 at 04:26, Tom Rini wrote: > > > > > > On Mon, Apr 12, 2021 at 10:21:18AM -0500, Alex G. wrote: > > > > > > > > > > > > On 4/12/21

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Tom Rini
On Tue, Apr 13, 2021 at 05:49:19AM +1200, Simon Glass wrote: > Hi Tom, Alex, > > On Tue, 13 Apr 2021 at 04:26, Tom Rini wrote: > > > > On Mon, Apr 12, 2021 at 10:21:18AM -0500, Alex G. wrote: > > > > > > > > > On 4/12/21 9:40 AM, Tom Rini wrote: > > > > On Mon, Apr 12, 2021 at 08:51:11AM -0500,

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Simon Glass
Hi Tom, Alex, On Tue, 13 Apr 2021 at 04:26, Tom Rini wrote: > > On Mon, Apr 12, 2021 at 10:21:18AM -0500, Alex G. wrote: > > > > > > On 4/12/21 9:40 AM, Tom Rini wrote: > > > On Mon, Apr 12, 2021 at 08:51:11AM -0500, Alex G. wrote: > > > > > > > > > > > > On 4/12/21 8:25 AM, Tom Rini wrote: > >

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Tom Rini
On Mon, Apr 12, 2021 at 10:21:18AM -0500, Alex G. wrote: > > > On 4/12/21 9:40 AM, Tom Rini wrote: > > On Mon, Apr 12, 2021 at 08:51:11AM -0500, Alex G. wrote: > > > > > > > > > On 4/12/21 8:25 AM, Tom Rini wrote: > > > > On Fri, Apr 09, 2021 at 05:29:36PM -0700, Tim Harvey wrote: > > > > > On

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Alex G.
On 4/12/21 9:40 AM, Tom Rini wrote: On Mon, Apr 12, 2021 at 08:51:11AM -0500, Alex G. wrote: On 4/12/21 8:25 AM, Tom Rini wrote: On Fri, Apr 09, 2021 at 05:29:36PM -0700, Tim Harvey wrote: On Fri, Apr 9, 2021 at 1:53 PM Tom Rini wrote: On Fri, Apr 09, 2021 at 03:24:41PM -0500, Adam

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Tom Rini
On Mon, Apr 12, 2021 at 08:51:11AM -0500, Alex G. wrote: > > > On 4/12/21 8:25 AM, Tom Rini wrote: > > On Fri, Apr 09, 2021 at 05:29:36PM -0700, Tim Harvey wrote: > > > On Fri, Apr 9, 2021 at 1:53 PM Tom Rini wrote: > > > > > > > > On Fri, Apr 09, 2021 at 03:24:41PM -0500, Adam Ford wrote: > >

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Alex G.
On 4/12/21 8:25 AM, Tom Rini wrote: On Fri, Apr 09, 2021 at 05:29:36PM -0700, Tim Harvey wrote: On Fri, Apr 9, 2021 at 1:53 PM Tom Rini wrote: On Fri, Apr 09, 2021 at 03:24:41PM -0500, Adam Ford wrote: On Fri, Apr 9, 2021 at 2:20 PM Alex G. wrote: Hi Simon On 4/8/21 6:55 PM, Simon

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-12 Thread Tom Rini
On Fri, Apr 09, 2021 at 05:29:36PM -0700, Tim Harvey wrote: > On Fri, Apr 9, 2021 at 1:53 PM Tom Rini wrote: > > > > On Fri, Apr 09, 2021 at 03:24:41PM -0500, Adam Ford wrote: > > > On Fri, Apr 9, 2021 at 2:20 PM Alex G. wrote: > > > > > > > > Hi Simon > > > > > > > > On 4/8/21 6:55 PM, Simon

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-09 Thread Tim Harvey
On Fri, Apr 9, 2021 at 1:53 PM Tom Rini wrote: > > On Fri, Apr 09, 2021 at 03:24:41PM -0500, Adam Ford wrote: > > On Fri, Apr 9, 2021 at 2:20 PM Alex G. wrote: > > > > > > Hi Simon > > > > > > On 4/8/21 6:55 PM, Simon Glass wrote: > > > > Hi Alexandru, > > > > > > > > On Fri, 9 Apr 2021 at

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-09 Thread Tom Rini
On Fri, Apr 09, 2021 at 03:24:41PM -0500, Adam Ford wrote: > On Fri, Apr 9, 2021 at 2:20 PM Alex G. wrote: > > > > Hi Simon > > > > On 4/8/21 6:55 PM, Simon Glass wrote: > > > Hi Alexandru, > > > > > > On Fri, 9 Apr 2021 at 04:56, Alexandru Gagniuc > > > wrote: > > >> > > >> This reverts commit

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-09 Thread Adam Ford
On Fri, Apr 9, 2021 at 2:20 PM Alex G. wrote: > > Hi Simon > > On 4/8/21 6:55 PM, Simon Glass wrote: > > Hi Alexandru, > > > > On Fri, 9 Apr 2021 at 04:56, Alexandru Gagniuc wrote: > >> > >> This reverts commit 38d6b7ebdaee3e0e8426ef1b9df88bdce8ae2e75. > >> > >> struct global_data contains a

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-09 Thread Alex G.
Hi Simon On 4/8/21 6:55 PM, Simon Glass wrote: Hi Alexandru, On Fri, 9 Apr 2021 at 04:56, Alexandru Gagniuc wrote: This reverts commit 38d6b7ebdaee3e0e8426ef1b9df88bdce8ae2e75. struct global_data contains a pointer to the bd_info structure. This pointer was populated spl_set_bd() to a

Re: [PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-08 Thread Simon Glass
Hi Alexandru, On Fri, 9 Apr 2021 at 04:56, Alexandru Gagniuc wrote: > > This reverts commit 38d6b7ebdaee3e0e8426ef1b9df88bdce8ae2e75. > > struct global_data contains a pointer to the bd_info structure. This > pointer was populated spl_set_bd() to a pre-allocated bd_info in the > ".data" section.

[PATCH] Revert "spl: Drop bd_info in the data section"

2021-04-08 Thread Alexandru Gagniuc
This reverts commit 38d6b7ebdaee3e0e8426ef1b9df88bdce8ae2e75. struct global_data contains a pointer to the bd_info structure. This pointer was populated spl_set_bd() to a pre-allocated bd_info in the ".data" section. The referenced commit replaced this mechanism to one that uses malloc(). That