Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

On Wed, Nov 15, 2023 at 06:35:23PM -0700, Simon Glass wrote: > EFI applications can be very large and thus used to cause boot failures > when malloc() space was exhausted. > > A recent changed fixed this by using the kernel_addr_r environment var > as the address of the buffer. However, it still

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

On Thu, Nov 16, 2023 at 1:35 AM Simon Glass wrote: > > EFI applications can be very large and thus used to cause boot failures > when malloc() space was exhausted. > > A recent changed fixed this by using the kernel_addr_r environment var > as the address of the buffer. However, it still frees

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

Hi Shantur, On Thu, 16 Nov 2023 at 09:45, Shantur Rathore wrote: > > Hi Simon, > > > > [please can you avoid top-posting as it makes it had for people to read > > later] > > > > Sure thing. Thanks! > > > There is a pending series there which I haven't got to yet. > > > I can add that change

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

On Thu, Nov 16, 2023 at 1:35 AM Simon Glass wrote: > > EFI applications can be very large and thus used to cause boot failures > when malloc() space was exhausted. > > A recent changed fixed this by using the kernel_addr_r environment var > as the address of the buffer. However, it still frees

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

Hi Simon, > [please can you avoid top-posting as it makes it had for people to read later] > Sure thing. > There is a pending series there which I haven't got to yet. > I can add that change to my bootmeth_efi dhcp fixes patch series if you want. > BTW, for this patch we need a test which

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

Hi Shantur, On Thu, 16 Nov 2023 at 04:02, Shantur Rathore wrote: > > Hi Simon, > > Thanks for the patch. > Ater this patch, booting off USB works fine over USB disk. > Maybe you need the same flag for dhcp as well just after dhcp_run() here >

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

Hi Simon, Thanks for the patch. Ater this patch, booting off USB works fine over USB disk. Maybe you need the same flag for dhcp as well just after dhcp_run() here https://github.com/u-boot/u-boot/blob/master/boot/bootmeth_efi.c#L356 Kind regards, Shantur On Thu, Nov 16, 2023 at 1:35 AM Simon

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

Hi Heinrich, On Wed, 15 Nov 2023 at 19:18, Heinrich Schuchardt wrote: > > On 11/16/23 02:35, Simon Glass wrote: > > EFI applications can be very large and thus used to cause boot failures > > when malloc() space was exhausted. > > > > A recent changed fixed this by using the kernel_addr_r

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

On 11/16/23 02:35, Simon Glass wrote: EFI applications can be very large and thus used to cause boot failures when malloc() space was exhausted. A recent changed fixed this by using the kernel_addr_r environment var as the address of the buffer. However, it still frees the buffer when the

[PATCH] bootstd: Avoid freeing a non-allocated buffer

EFI applications can be very large and thus used to cause boot failures when malloc() space was exhausted. A recent changed fixed this by using the kernel_addr_r environment var as the address of the buffer. However, it still frees the buffer when the bootflow is discarded. Fix this by