Re: caching BLOBLISTT_SPL_HANDOFF (was Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently)

2020-03-02 Thread Simon Glass
Hi Rasmus, On Fri, 28 Feb 2020 at 16:09, Rasmus Villemoes wrote: > > On 28/02/2020 18.35, Tom Rini wrote: > > On Fri, Feb 28, 2020 at 05:24:58PM +, Rasmus Villemoes wrote: > > >> eliminated, and there's not an #ifdef in sight. > > > > That sounds pretty nice actually. If you're so inclined

caching BLOBLISTT_SPL_HANDOFF (was Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently)

2020-02-28 Thread Rasmus Villemoes
On 28/02/2020 18.35, Tom Rini wrote: > On Fri, Feb 28, 2020 at 05:24:58PM +, Rasmus Villemoes wrote: >> eliminated, and there's not an #ifdef in sight. > > That sounds pretty nice actually. If you're so inclined I'd like to see > it. > So I started looking at that, and while it's mostly

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-28 Thread Tom Rini
On Fri, Feb 28, 2020 at 05:24:58PM +, Rasmus Villemoes wrote: > On 28/02/2020 16.46, Tom Rini wrote: > > On Fri, Feb 28, 2020 at 08:42:21AM +, Rasmus Villemoes wrote: > >> On 28/02/2020 00.40, Simon Glass wrote: > > >>> Using if() is preferable to #if if there is no cost. > >> > >>

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-28 Thread Rasmus Villemoes
On 28/02/2020 16.46, Tom Rini wrote: > On Fri, Feb 28, 2020 at 08:42:21AM +, Rasmus Villemoes wrote: >> On 28/02/2020 00.40, Simon Glass wrote: >>> Using if() is preferable to #if if there is no cost. >> >> Completely agree, and I also prefer to have the linker eliminate unused >> functions

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-28 Thread Tom Rini
On Fri, Feb 28, 2020 at 08:42:21AM +, Rasmus Villemoes wrote: > On 28/02/2020 00.40, Simon Glass wrote: > > Hi Rasmus, > > > > On Thu, 27 Feb 2020 at 00:18, Rasmus Villemoes > > wrote: > >> > >> Some init functions, e.g. print_resetinfo(), are conditionally defined > >> depending on some

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-28 Thread Rasmus Villemoes
On 28/02/2020 00.40, Simon Glass wrote: > Hi Rasmus, > > On Thu, 27 Feb 2020 at 00:18, Rasmus Villemoes > wrote: >> >> Some init functions, e.g. print_resetinfo(), are conditionally defined >> depending on some config options, and are correspondingly >> conditionally included in the

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-27 Thread Simon Glass
Hi Rasmus, On Thu, 27 Feb 2020 at 00:18, Rasmus Villemoes wrote: > > Some init functions, e.g. print_resetinfo(), are conditionally defined > depending on some config options, and are correspondingly > conditionally included in the init_sequence_f[] array. > > Others are unconditionally defined

[PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-27 Thread Rasmus Villemoes
Some init functions, e.g. print_resetinfo(), are conditionally defined depending on some config options, and are correspondingly conditionally included in the init_sequence_f[] array. Others are unconditionally defined and included in init_sequence_f[], but have their entire body, sans a