Re: [PATCH] configs: rockchip: rock5a: enable environment
Hi Eugen, On 2024/3/5 13:40, Eugen Hristev wrote: On 3/5/24 04:10, Trevor Woerner wrote: Following the pattern of other Rockchip devices, enable the U-Boot environment to be stored in MMC. This patch specifically assumes the environment will be stored on the SDcard. Signed-off-by: Trevor Woerner --- configs/rock5a-rk3588s_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig index a6471a519514..ac6411667d9a 100644 --- a/configs/rock5a-rk3588s_defconfig +++ b/configs/rock5a-rk3588s_defconfig @@ -8,6 +8,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y CONFIG_NR_DRAM_BANKS=2 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc0 +CONFIG_ENV_SIZE=0x8000 CONFIG_DEFAULT_DEVICE_TREE="rk3588s-rock-5a" CONFIG_ROCKCHIP_RK3588=y CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y @@ -48,6 +49,8 @@ CONFIG_CMD_REGULATOR=y CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIVE=y CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SPL_REGMAP=y CONFIG_SPL_SYSCON=y Hi Trevor, What will happen if there is no Sd-Card, and we boot from eMMC or SPI flash ? The U-Boot should boot correctly with default env, and without any env from storage. The env is used for U-Boot preoper, they should come from the same storage. The rockchip pattern is usually to have a standard config for all boards and it is not stored anywhere. Do you mean rockchip vendor U-Boot? I think rockchip vendor U-Boot does not depends on the env on storage, it use default env for boot process and a vendor defined "vendor storage" for MAC/SN. Thanks, - Kever Kever, Jonas, please correct me if I am wrong. Eugen
Re: [PATCH] configs: rockchip: rock5a: enable environment
On 2024-03-05 14:45, Trevor Woerner wrote: > On Tue 2024-03-05 @ 10:17:10 AM, Jonas Karlman wrote: >> Hi, >> >> On 2024-03-05 06:40, Eugen Hristev wrote: >>> On 3/5/24 04:10, Trevor Woerner wrote: Following the pattern of other Rockchip devices, enable the U-Boot environment to be stored in MMC. This patch specifically assumes the environment will be stored on the SDcard. Signed-off-by: Trevor Woerner --- configs/rock5a-rk3588s_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig index a6471a519514..ac6411667d9a 100644 --- a/configs/rock5a-rk3588s_defconfig +++ b/configs/rock5a-rk3588s_defconfig @@ -8,6 +8,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y CONFIG_NR_DRAM_BANKS=2 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc0 +CONFIG_ENV_SIZE=0x8000 CONFIG_DEFAULT_DEVICE_TREE="rk3588s-rock-5a" CONFIG_ROCKCHIP_RK3588=y CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y @@ -48,6 +49,8 @@ CONFIG_CMD_REGULATOR=y CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIVE=y CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SPL_REGMAP=y CONFIG_SPL_SYSCON=y >>> >>> >>> Hi Trevor, >>> >>> What will happen if there is no Sd-Card, and we boot from eMMC or SPI flash >>> ? >> >> Agree, we should not blindly enable env and expect that it can be stored >> on sd-card. If anything, it should preferably be saved/loaded from the >> device where TPL/SPL was booted from. >> >> Personally I always run my devices with ENV_IS_NOWHERE, with standard >> boot and extlinux or efi as the preferred way to boot, I do not see why >> normal end-users with a single OS really have a need for a saved env, >> please educate me :-) > > I am the maintainer of the meta-rockchip Yocto layer[1]. Yocto uses a > nifty tool called 'wic' to layout images (dos/gpt partitioning, optionally > formatting partitions, optionally installing things into those partitions)[2]. > The partitioning layout that we follow is the one that is recommended by > Rockchip itself[3] with 2 exceptions: > - we don't hide any of the partitions from the partition table > - we've combined /boot into the root partition (for reasons I'll explain > later) > > Under the Rockchip partitioning, the U-Boot environment is stored in partition > 5, at offset 0x0003.f800, and has a size of 0x.8000. Not sure you should look too much at the Rockchip partitioning, not sure it is something to promote for mainline Linux and U-Boot usage. The partitions is not correct/relevant, especially for aarch64. For mainline the following offsets are typically only used: - 0x8000: TPL+SPL - up to around 256+256 KiB - 0x003F8000: optional U-Boot env - 0x0080: FIT with U-Boot proper + TF-A and/or OPTEE, or U-Boot proper in legacy image format - 0x0100+: free use It is highly recommended to write the generated u-boot-rockchip.bin to sector 0x40 of mmc to get all the U-Boot related offsets correct as defined in board defconfig. To me the traditional Rockchip partitioning scheme does not really fill any purpose with mainline Linux and U-Boot, please enlighten me :-) One thing that vendor U-Boot does that possible could be adopted for mainline U-Boot is that it will locate FIT based on a GPT partition named "uboot" and fallback to traditional sector 0x4000. The offsets and size of traditional Rockchip partitioning scheme is no longer that important for vendor U-Boot/Linux. It is also possible to reclaim some of the wasted space by putting FIT at a different location, e.g: - 0x8000: TPL+SPL - up to around 256+256 KiB - 0x00088000: FIT with U-Boot proper + TF-A - up to 3520 KiB - 0x003F8000: optional U-Boot env - 0x0040+: free use > > I don't own every Rockchip board, but I have a bunch of them (thanks to some > generous donations!). I've created a spreadsheet that lists the ones supported > by meta-rockchip and their environment variable U-Boot configurations > (locations, offsets, sizes). Most of them follow the Rockchip recommended > partitioning layout with regards to storing the environment. This set of > patches closes that gap, at least for the ones supported by meta-rockchip. > > One of the things that I want to do next with meta-rockchip is to provide > an easy way for users to enable some sort of A/B OTA update strategy. > Currently, enabling an A/B update mechanism for any board (Rockchip or not) > is a non-trivial exercise. Every A/B update mechanism that I've looked at > requires (among other things) the bootloader to be able to store/retrieve > its environment from U-Boot itself (obviously) and also from Linux userspace > since it is the bootloader that ultimately
Re: [PATCH] configs: rockchip: rock5a: enable environment
On Tue 2024-03-05 @ 10:17:10 AM, Jonas Karlman wrote: > Hi, > > On 2024-03-05 06:40, Eugen Hristev wrote: > > On 3/5/24 04:10, Trevor Woerner wrote: > >> Following the pattern of other Rockchip devices, enable the U-Boot > >> environment to be stored in MMC. This patch specifically assumes the > >> environment will be stored on the SDcard. > >> > >> Signed-off-by: Trevor Woerner > >> --- > >> configs/rock5a-rk3588s_defconfig | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/configs/rock5a-rk3588s_defconfig > >> b/configs/rock5a-rk3588s_defconfig > >> index a6471a519514..ac6411667d9a 100644 > >> --- a/configs/rock5a-rk3588s_defconfig > >> +++ b/configs/rock5a-rk3588s_defconfig > >> @@ -8,6 +8,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y > >> CONFIG_NR_DRAM_BANKS=2 > >> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > >> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc0 > >> +CONFIG_ENV_SIZE=0x8000 > >> CONFIG_DEFAULT_DEVICE_TREE="rk3588s-rock-5a" > >> CONFIG_ROCKCHIP_RK3588=y > >> CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y > >> @@ -48,6 +49,8 @@ CONFIG_CMD_REGULATOR=y > >> CONFIG_SPL_OF_CONTROL=y > >> CONFIG_OF_LIVE=y > >> CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks > >> assigned-clock-rates assigned-clock-parents" > >> +CONFIG_ENV_IS_IN_MMC=y > >> +CONFIG_SYS_MMC_ENV_DEV=1 > >> CONFIG_SPL_DM_SEQ_ALIAS=y > >> CONFIG_SPL_REGMAP=y > >> CONFIG_SPL_SYSCON=y > > > > > > Hi Trevor, > > > > What will happen if there is no Sd-Card, and we boot from eMMC or SPI flash > > ? > > Agree, we should not blindly enable env and expect that it can be stored > on sd-card. If anything, it should preferably be saved/loaded from the > device where TPL/SPL was booted from. > > Personally I always run my devices with ENV_IS_NOWHERE, with standard > boot and extlinux or efi as the preferred way to boot, I do not see why > normal end-users with a single OS really have a need for a saved env, > please educate me :-) I am the maintainer of the meta-rockchip Yocto layer[1]. Yocto uses a nifty tool called 'wic' to layout images (dos/gpt partitioning, optionally formatting partitions, optionally installing things into those partitions)[2]. The partitioning layout that we follow is the one that is recommended by Rockchip itself[3] with 2 exceptions: - we don't hide any of the partitions from the partition table - we've combined /boot into the root partition (for reasons I'll explain later) Under the Rockchip partitioning, the U-Boot environment is stored in partition 5, at offset 0x0003.f800, and has a size of 0x.8000. I don't own every Rockchip board, but I have a bunch of them (thanks to some generous donations!). I've created a spreadsheet that lists the ones supported by meta-rockchip and their environment variable U-Boot configurations (locations, offsets, sizes). Most of them follow the Rockchip recommended partitioning layout with regards to storing the environment. This set of patches closes that gap, at least for the ones supported by meta-rockchip. One of the things that I want to do next with meta-rockchip is to provide an easy way for users to enable some sort of A/B OTA update strategy. Currently, enabling an A/B update mechanism for any board (Rockchip or not) is a non-trivial exercise. Every A/B update mechanism that I've looked at requires (among other things) the bootloader to be able to store/retrieve its environment from U-Boot itself (obviously) and also from Linux userspace since it is the bootloader that ultimately boots from either the A or the B partition. I'm specifically focused on rauc, but all the A/B update mechanisms I've looked at have this same requirement. Users who don't care for A/B updates can simply use meta-rockchip as-is, those who want an A/B strategy would simply enable a setting or two in their Yocto config and meta-rockchip would take care of the details, regardless of which Rockchip board they're using. I've combined /boot into the root partition since it makes A/B updates easier. Otherwise in order to work it would actually be an Aboot+Aroot/Bboot+Broot mechanism, which is clumsy. Also since U-Boot is stored in partition by itself, the only thing in the /boot partition is the U-Boot boot mechanism (boot script, extlinux, etc), the Linux kernel, and the DTB (or fitImage). In general it's better to keep the kernel and the root filesystem in sync, so having a separate /boot partition is clumsy for no gain. The other nice thing about wic is that it allows us to store random data (or filesystems) in the image as we're creating it for the first time. In other words, I have a mechanism that allows me to create the initial/default U-Boot environment during the build, I can add or remove variables from it dynamically as part of my build process, generate the proper binary blob of that environment (i.e. with checksum), and lay it out into partition 5 of the generated image so that on first boot the environment is already setup with whatever U-Boot needs
Re: [PATCH] configs: rockchip: rock5a: enable environment
Hi, On 2024-03-05 06:40, Eugen Hristev wrote: > On 3/5/24 04:10, Trevor Woerner wrote: >> Following the pattern of other Rockchip devices, enable the U-Boot >> environment to be stored in MMC. This patch specifically assumes the >> environment will be stored on the SDcard. >> >> Signed-off-by: Trevor Woerner >> --- >> configs/rock5a-rk3588s_defconfig | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/configs/rock5a-rk3588s_defconfig >> b/configs/rock5a-rk3588s_defconfig >> index a6471a519514..ac6411667d9a 100644 >> --- a/configs/rock5a-rk3588s_defconfig >> +++ b/configs/rock5a-rk3588s_defconfig >> @@ -8,6 +8,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y >> CONFIG_NR_DRAM_BANKS=2 >> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y >> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc0 >> +CONFIG_ENV_SIZE=0x8000 >> CONFIG_DEFAULT_DEVICE_TREE="rk3588s-rock-5a" >> CONFIG_ROCKCHIP_RK3588=y >> CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y >> @@ -48,6 +49,8 @@ CONFIG_CMD_REGULATOR=y >> CONFIG_SPL_OF_CONTROL=y >> CONFIG_OF_LIVE=y >> CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks >> assigned-clock-rates assigned-clock-parents" >> +CONFIG_ENV_IS_IN_MMC=y >> +CONFIG_SYS_MMC_ENV_DEV=1 >> CONFIG_SPL_DM_SEQ_ALIAS=y >> CONFIG_SPL_REGMAP=y >> CONFIG_SPL_SYSCON=y > > > Hi Trevor, > > What will happen if there is no Sd-Card, and we boot from eMMC or SPI flash ? Agree, we should not blindly enable env and expect that it can be stored on sd-card. If anything, it should preferably be saved/loaded from the device where TPL/SPL was booted from. Personally I always run my devices with ENV_IS_NOWHERE, with standard boot and extlinux or efi as the preferred way to boot, I do not see why normal end-users with a single OS really have a need for a saved env, please educate me :-) > > The rockchip pattern is usually to have a standard config for all boards and > it is > not stored anywhere. Unfortunately lots of rockchip boards have blindly enabled ENV_IN_MMC and force it to use sd-card. However, before enabling same forced behavior on new boards I would recommend ensuring adding support for allowing env to follow same load order as FIT (spl-boot-order). Regards, Jonas > > Kever, Jonas, please correct me if I am wrong. > > Eugen
Re: [PATCH] configs: rockchip: rock5a: enable environment
On 3/5/24 04:10, Trevor Woerner wrote: > Following the pattern of other Rockchip devices, enable the U-Boot > environment to be stored in MMC. This patch specifically assumes the > environment will be stored on the SDcard. > > Signed-off-by: Trevor Woerner > --- > configs/rock5a-rk3588s_defconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configs/rock5a-rk3588s_defconfig > b/configs/rock5a-rk3588s_defconfig > index a6471a519514..ac6411667d9a 100644 > --- a/configs/rock5a-rk3588s_defconfig > +++ b/configs/rock5a-rk3588s_defconfig > @@ -8,6 +8,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y > CONFIG_NR_DRAM_BANKS=2 > CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc0 > +CONFIG_ENV_SIZE=0x8000 > CONFIG_DEFAULT_DEVICE_TREE="rk3588s-rock-5a" > CONFIG_ROCKCHIP_RK3588=y > CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y > @@ -48,6 +49,8 @@ CONFIG_CMD_REGULATOR=y > CONFIG_SPL_OF_CONTROL=y > CONFIG_OF_LIVE=y > CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks > assigned-clock-rates assigned-clock-parents" > +CONFIG_ENV_IS_IN_MMC=y > +CONFIG_SYS_MMC_ENV_DEV=1 > CONFIG_SPL_DM_SEQ_ALIAS=y > CONFIG_SPL_REGMAP=y > CONFIG_SPL_SYSCON=y Hi Trevor, What will happen if there is no Sd-Card, and we boot from eMMC or SPI flash ? The rockchip pattern is usually to have a standard config for all boards and it is not stored anywhere. Kever, Jonas, please correct me if I am wrong. Eugen
[PATCH] configs: rockchip: rock5a: enable environment
Following the pattern of other Rockchip devices, enable the U-Boot environment to be stored in MMC. This patch specifically assumes the environment will be stored on the SDcard. Signed-off-by: Trevor Woerner --- configs/rock5a-rk3588s_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig index a6471a519514..ac6411667d9a 100644 --- a/configs/rock5a-rk3588s_defconfig +++ b/configs/rock5a-rk3588s_defconfig @@ -8,6 +8,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y CONFIG_NR_DRAM_BANKS=2 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc0 +CONFIG_ENV_SIZE=0x8000 CONFIG_DEFAULT_DEVICE_TREE="rk3588s-rock-5a" CONFIG_ROCKCHIP_RK3588=y CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y @@ -48,6 +49,8 @@ CONFIG_CMD_REGULATOR=y CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIVE=y CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SPL_REGMAP=y CONFIG_SPL_SYSCON=y -- 2.43.0.76.g1a87c842ece3
