Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-14 Thread Shantur Rathore
Hi Jonas / Simon, I have submitted a patch based on Jonas's suggestion. Apologies, I am new to email based patch management and it went as new thread (at least for me) It's here - https://lore.kernel.org/u-boot/20231114203309.852289-...@shantur.com/ Kind regards, Shantur On Mon, Nov 13, 2023

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Shantur Rathore
Hey Jonas, This sounds like a good idea. Please implement this. Kind regards, Shantur On Sun, Nov 12, 2023 at 3:01 PM Jonas Karlman wrote: > > Hi Shantur, > > On 2023-11-12 15:21, Shantur Rathore wrote: > > Hey Jonas, > > > >> For normal generic use the full bootstd commands should not be

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Simon Glass
Hi Jonas, On Sun, 12 Nov 2023 at 07:53, Jonas Karlman wrote: > > Hi Simon, > > On 2023-11-12 15:22, Simon Glass wrote: > > Hi Jonas, > > > > On Sun, 12 Nov 2023 at 05:50, Jonas Karlman wrote: > >> > >> Hi Shantur, > >> > >> On 2023-11-12 13:34, Shantur Rathore wrote: > >>> Hi Jonas, > >>> >

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Jonas Karlman
Hi Shantur, On 2023-11-12 15:21, Shantur Rathore wrote: > Hey Jonas, > >> For normal generic use the full bootstd commands should not be needed, >> do you have special scripting requirements that require access to full >> bootstd commands? >> >> All rockchip boards use standard boot, this only

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Jonas Karlman
Hi Simon, On 2023-11-12 15:22, Simon Glass wrote: > Hi Jonas, > > On Sun, 12 Nov 2023 at 05:50, Jonas Karlman wrote: >> >> Hi Shantur, >> >> On 2023-11-12 13:34, Shantur Rathore wrote: >>> Hi Jonas, >>> The CMD_SPI is not used to interact with the SPI flash. CMD_SF is already

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Simon Glass
Hi Jonas, On Sun, 12 Nov 2023 at 05:50, Jonas Karlman wrote: > > Hi Shantur, > > On 2023-11-12 13:34, Shantur Rathore wrote: > > Hi Jonas, > > > >> The CMD_SPI is not used to interact with the SPI flash. > >> > >> CMD_SF is already enabled and you can use "sf probe" and any other sf > >> related

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Shantur Rathore
Hey Jonas, > For normal generic use the full bootstd commands should not be needed, > do you have special scripting requirements that require access to full > bootstd commands? > > All rockchip boards use standard boot, this only enables full commands > for one particular board, why is this board

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Jonas Karlman
Hi Shantur, On 2023-11-12 13:34, Shantur Rathore wrote: > Hi Jonas, > >> The CMD_SPI is not used to interact with the SPI flash. >> >> CMD_SF is already enabled and you can use "sf probe" and any other sf >> related action to interact with the SPI flash on this board. >> > > You are right, this

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Shantur Rathore
Hi Jonas, > The CMD_SPI is not used to interact with the SPI flash. > > CMD_SF is already enabled and you can use "sf probe" and any other sf > related action to interact with the SPI flash on this board. > You are right, this is not needed, thanks for correcting me. I will update my patch. >

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Jonas Karlman
On 2023-11-11 01:13, Shantur Rathore wrote: > RockPro64 has a 16MB onboard SPI chip and current u-boot takes > around 2MB, we can enable more features. > Updating config to enable SPI commands and full BootSTD support. > --- > configs/rockpro64-rk3399_defconfig | 2 ++ > 1 file changed, 2

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-11 Thread Simon Glass
Hi Shantur, On Fri, 10 Nov 2023 at 17:14, Shantur Rathore wrote: > > RockPro64 has a 16MB onboard SPI chip and current u-boot takes > around 2MB, we can enable more features. What takes 2MB? I have never seen U-Boot get close to that large! Regards, Simon > Updating config to enable SPI

[PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-10 Thread Shantur Rathore
RockPro64 has a 16MB onboard SPI chip and current u-boot takes around 2MB, we can enable more features. Updating config to enable SPI commands and full BootSTD support. --- configs/rockpro64-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig