Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/3/20 1:32 AM, Tom Rini wrote: > On Tue, Jun 02, 2020 at 09:06:42PM +0200, Marek Vasut wrote: >> On 6/2/20 7:36 PM, Tom Rini wrote: >> [...] One will append the environment, the other will override it (if you have multiple envs enabled). >>> >>> So it sounds

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Tom Rini
On Tue, Jun 02, 2020 at 09:06:42PM +0200, Marek Vasut wrote: > On 6/2/20 7:36 PM, Tom Rini wrote: > [...] > >> One will append the environment, the other will override it (if you > >> have > >> multiple envs enabled). > > > > So it sounds like it wouldn't be valid to have this

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/2/20 7:36 PM, Tom Rini wrote: [...] >> One will append the environment, the other will override it (if you have >> multiple envs enabled). > > So it sounds like it wouldn't be valid to have this option differ > between SPL and main U-Boot? Consider the case where

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Tom Rini
On Tue, Jun 02, 2020 at 06:06:17PM +0200, Marek Vasut wrote: > On 6/2/20 6:00 PM, Tom Rini wrote: > > On Tue, Jun 02, 2020 at 05:55:25PM +0200, Marek Vasut wrote: > >> On 6/2/20 4:38 PM, Tom Rini wrote: > >>> On Tue, Jun 02, 2020 at 02:47:12PM +0200, Marek Vasut wrote: > On 6/2/20 2:44 PM,

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/2/20 6:00 PM, Tom Rini wrote: > On Tue, Jun 02, 2020 at 05:55:25PM +0200, Marek Vasut wrote: >> On 6/2/20 4:38 PM, Tom Rini wrote: >>> On Tue, Jun 02, 2020 at 02:47:12PM +0200, Marek Vasut wrote: On 6/2/20 2:44 PM, Tom Rini wrote: > On Tue, Jun 02, 2020 at 02:05:39PM +0200, Rasmus

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Tom Rini
On Tue, Jun 02, 2020 at 05:55:25PM +0200, Marek Vasut wrote: > On 6/2/20 4:38 PM, Tom Rini wrote: > > On Tue, Jun 02, 2020 at 02:47:12PM +0200, Marek Vasut wrote: > >> On 6/2/20 2:44 PM, Tom Rini wrote: > >>> On Tue, Jun 02, 2020 at 02:05:39PM +0200, Rasmus Villemoes wrote: > On 02/06/2020

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/2/20 4:38 PM, Tom Rini wrote: > On Tue, Jun 02, 2020 at 02:47:12PM +0200, Marek Vasut wrote: >> On 6/2/20 2:44 PM, Tom Rini wrote: >>> On Tue, Jun 02, 2020 at 02:05:39PM +0200, Rasmus Villemoes wrote: On 02/06/2020 13.04, Marek Vasut wrote: > On 6/2/20 8:42 AM, Rasmus Villemoes

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/2/20 4:43 PM, Tom Rini wrote: > On Tue, Jun 02, 2020 at 02:09:57PM +0200, Marek Vasut wrote: >> On 6/2/20 2:05 PM, Rasmus Villemoes wrote: >>> On 02/06/2020 13.04, Marek Vasut wrote: On 6/2/20 8:42 AM, Rasmus Villemoes wrote: > On 29/05/2020 19.54, Marek Vasut wrote: >> +config

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Tom Rini
On Tue, Jun 02, 2020 at 02:09:57PM +0200, Marek Vasut wrote: > On 6/2/20 2:05 PM, Rasmus Villemoes wrote: > > On 02/06/2020 13.04, Marek Vasut wrote: > >> On 6/2/20 8:42 AM, Rasmus Villemoes wrote: > >>> On 29/05/2020 19.54, Marek Vasut wrote: > +config ENV_APPEND > +bool "Always

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Tom Rini
On Tue, Jun 02, 2020 at 02:47:12PM +0200, Marek Vasut wrote: > On 6/2/20 2:44 PM, Tom Rini wrote: > > On Tue, Jun 02, 2020 at 02:05:39PM +0200, Rasmus Villemoes wrote: > >> On 02/06/2020 13.04, Marek Vasut wrote: > >>> On 6/2/20 8:42 AM, Rasmus Villemoes wrote: > On 29/05/2020 19.54, Marek

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/2/20 2:05 PM, Rasmus Villemoes wrote: > On 02/06/2020 13.04, Marek Vasut wrote: >> On 6/2/20 8:42 AM, Rasmus Villemoes wrote: >>> On 29/05/2020 19.54, Marek Vasut wrote: +config ENV_APPEND + bool "Always append the environment with new data" + default n + help +

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/2/20 2:44 PM, Tom Rini wrote: > On Tue, Jun 02, 2020 at 02:05:39PM +0200, Rasmus Villemoes wrote: >> On 02/06/2020 13.04, Marek Vasut wrote: >>> On 6/2/20 8:42 AM, Rasmus Villemoes wrote: On 29/05/2020 19.54, Marek Vasut wrote: > +config ENV_APPEND > + bool "Always append the

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Tom Rini
On Tue, Jun 02, 2020 at 02:05:39PM +0200, Rasmus Villemoes wrote: > On 02/06/2020 13.04, Marek Vasut wrote: > > On 6/2/20 8:42 AM, Rasmus Villemoes wrote: > >> On 29/05/2020 19.54, Marek Vasut wrote: > >>> +config ENV_APPEND > >>> + bool "Always append the environment with new data" > >>> +

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Rasmus Villemoes
On 02/06/2020 13.04, Marek Vasut wrote: > On 6/2/20 8:42 AM, Rasmus Villemoes wrote: >> On 29/05/2020 19.54, Marek Vasut wrote: >>> +config ENV_APPEND >>> + bool "Always append the environment with new data" >>> + default n >>> + help >>> + If defined, the environment hash table is only

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Marek Vasut
On 6/2/20 8:42 AM, Rasmus Villemoes wrote: > On 29/05/2020 19.54, Marek Vasut wrote: >> +config ENV_APPEND >> +bool "Always append the environment with new data" >> +default n >> +help >> + If defined, the environment hash table is only ever appended with new >> + data, but

Re: [PATCH] env: Add option to only ever append environment

2020-06-02 Thread Rasmus Villemoes
On 29/05/2020 19.54, Marek Vasut wrote: > +config ENV_APPEND > + bool "Always append the environment with new data" > + default n > + help > + If defined, the environment hash table is only ever appended with new > + data, but the existing hash table can never be dropped

[PATCH] env: Add option to only ever append environment

2020-05-29 Thread Marek Vasut
Add configuration option which prevents the environment hash table to be ever cleared and reloaded with different content. This is useful in case the first environment loaded into the hash table contains e.g. sensitive content which must not be dropped or reloaded. Signed-off-by: Marek Vasut ---