Re: [PATCH] image-board: fix wrong implementation ram disk address setup from cmdline

Hi Art, On Mon, 1 Nov 2021 at 00:52, Art Nikpal wrote: > > hi Simon > > > Fixes: f33a2c1bd0f ("image: Remove #ifdefs from select_ramdisk()") > > (I believe, can you confirm?) > > confirm f33a2c1bd0f has wrong implementation logic for raw ramdisk image > sure i have tested it ... Thanks! BTW

Re: [PATCH] image-board: fix wrong implementation ram disk address setup from cmdline

hi Simon > Fixes: f33a2c1bd0f ("image: Remove #ifdefs from select_ramdisk()") > (I believe, can you confirm?) confirm f33a2c1bd0f has wrong implementation logic for raw ramdisk image sure i have tested it ... On Mon, Nov 1, 2021 at 7:47 AM Simon Glass wrote: > > Hi Artem, > > On Fri, 15 Oct

Re: [PATCH] image-board: fix wrong implementation ram disk address setup from cmdline

Hi Artem, On Fri, 15 Oct 2021 at 23:19, Artem Lapkin wrote: > > Problem > > Wrong implementation logic: ramdisk cmdline image address always ignored! > Next block { rd_addr = hextoul(select, NULL) } unusable for raw initrd. > > We have unbootable raw initrd images because, select_ramdisk for raw

[PATCH] image-board: fix wrong implementation ram disk address setup from cmdline

Problem Wrong implementation logic: ramdisk cmdline image address always ignored! Next block { rd_addr = hextoul(select, NULL) } unusable for raw initrd. We have unbootable raw initrd images because, select_ramdisk for raw initrd images ignore submited select addr and setup rd_datap value to 0