Re: [PATCH] include/eeprom.h: fix build errors

2020-05-07 Thread Rasmus Villemoes
On 07/05/2020 15.03, Tom Rini wrote: > On Tue, Feb 18, 2020 at 08:39:42AM +, Rasmus Villemoes wrote: > >> Signed-off-by: Rasmus Villemoes >> Reviewed-by: Tom Rini > > [I had asked for a follow-up cleanup, but this is still worth taking, > so...] Yeah, sorry, been rather busy, dunno when

Re: [PATCH] include/eeprom.h: fix build errors

2020-05-07 Thread Tom Rini
On Tue, Feb 18, 2020 at 08:39:42AM +, Rasmus Villemoes wrote: > CMD_EEPROM and ENV_IS_IN_EEPROM can be selected independently, and > cmd/eeprom.o gets built in either case, so whether to declare the real > prototypes needs to follow the same logic as whether cmd/eeprom.c is > built. Otherwise

Re: [PATCH] include/eeprom.h: fix build errors

2020-02-18 Thread Tom Rini
On Tue, Feb 18, 2020 at 08:39:42AM +, Rasmus Villemoes wrote: > CMD_EEPROM and ENV_IS_IN_EEPROM can be selected independently, and > cmd/eeprom.o gets built in either case, so whether to declare the real > prototypes needs to follow the same logic as whether cmd/eeprom.c is > built. Otherwise

[PATCH] include/eeprom.h: fix build errors

2020-02-18 Thread Rasmus Villemoes
CMD_EEPROM and ENV_IS_IN_EEPROM can be selected independently, and cmd/eeprom.o gets built in either case, so whether to declare the real prototypes needs to follow the same logic as whether cmd/eeprom.c is built. Otherwise a ENV_IS_IN_EEPROM=y, CMD_EEPROM=n build fails cmd/eeprom.c:73:1: error: