Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

[Jagan Teki]

Hi Bin,

On Fri, Oct 8, 2021 at 8:43 PM Bin Meng  wrote:
>
> HI Jagan,
>
> On Fri, Oct 8, 2021 at 8:58 PM Jagan Teki  wrote:
> >
> > On Thu, Sep 30, 2021 at 4:24 PM  wrote:
> > >
> > > From: "yanhong.wang" 
> > >
> > > Signed-off-by: yanhong.wang 
> > > ---
> >
> > Applied to u-boot-spi/master
>
> Did you address my comments when applying?

Yes.

Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

[Bin Meng]

HI Jagan,

On Fri, Oct 8, 2021 at 8:58 PM Jagan Teki  wrote:
>
> On Thu, Sep 30, 2021 at 4:24 PM  wrote:
> >
> > From: "yanhong.wang" 
> >
> > Signed-off-by: yanhong.wang 
> > ---
>
> Applied to u-boot-spi/master

Did you address my comments when applying?

Regards,
Bin

Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

[Jagan Teki]

On Thu, Sep 30, 2021 at 4:24 PM  wrote:
>
> From: "yanhong.wang" 
>
> Signed-off-by: yanhong.wang 
> ---

Applied to u-boot-spi/master

Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

[Bin Meng]

On Thu, Sep 30, 2021 at 6:55 PM  wrote:
>
> From: "yanhong.wang" 
>

Please add a brief commit message for this, like providing a datasheet
for reference:

https://www.gigadevice.com/datasheet/gd25lq256d/

> Signed-off-by: yanhong.wang 

I believe the name should be spelled as "Yanhong Wang"

> ---
>  drivers/mtd/spi/spi-nor-ids.c | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e..35fa347c44 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> },
> +   {
> +   INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
> +   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +   SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +   },
>  #endif
>  #ifdef CONFIG_SPI_FLASH_ISSI   /* ISSI */
> /* ISSI */

Otherwise LGTM:
Reviewed-by: Bin Meng 

[PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

[tekkamanv]

From: "yanhong.wang" 

Signed-off-by: yanhong.wang 
---
 drivers/mtd/spi/spi-nor-ids.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 4aef1ddd6e..35fa347c44 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
+   {
+   INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
+   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+   SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+   },
 #endif
 #ifdef CONFIG_SPI_FLASH_ISSI   /* ISSI */
/* ISSI */
-- 
2.25.4

[PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

[tekkamanv]

From: "yanhong.wang" 

Signed-off-by: yanhong.wang 
---
 drivers/mtd/spi/spi-nor-ids.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 4aef1ddd6e..35fa347c44 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
+   {
+   INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
+   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+   SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+   },
 #endif
 #ifdef CONFIG_SPI_FLASH_ISSI   /* ISSI */
/* ISSI */
-- 
2.25.4