Re: [PATCH] net: Remove ne2000 driver

2021-05-26 Thread Tom Rini
On Tue, May 25, 2021 at 11:54:41AM -0400, Tom Rini wrote:

> With the last user of this driver removed, remove the driver.
> 
> Signed-off-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH] net: Remove ne2000 driver

2021-05-25 Thread Tom Rini
On Tue, May 25, 2021 at 06:27:27PM +0200, Daniel Schwierzeck wrote:
> Am Dienstag, den 25.05.2021, 11:54 -0400 schrieb Tom Rini:
> > With the last user of this driver removed, remove the driver.
> > 
> > Signed-off-by: Tom Rini 
> > ---
> >  doc/README.ne2000 |  27 --
> >  drivers/net/8390.h| 124 --
> >  drivers/net/Makefile  |   1 -
> >  drivers/net/ne2000.c  | 260 -
> >  drivers/net/ne2000.h  |  94 -
> >  drivers/net/ne2000_base.c | 792 
> > --
> >  drivers/net/ne2000_base.h | 305 ---
> >  7 files changed, 1603 deletions(-)
> >  delete mode 100644 doc/README.ne2000
> >  delete mode 100644 drivers/net/8390.h
> >  delete mode 100644 drivers/net/ne2000.c
> >  delete mode 100644 drivers/net/ne2000.h
> >  delete mode 100644 drivers/net/ne2000_base.c
> >  delete mode 100644 drivers/net/ne2000_base.h
> 
> Reviewed-by: Daniel Schwierzeck 
> 
> There are still some references in config_whitelist.txt:
> 
> $ git grep -in ne2000 -- scripts/config_whitelist.txt
> scripts/config_whitelist.txt:303:CONFIG_DRIVER_NE2000
> scripts/config_whitelist.txt:304:CONFIG_DRIVER_NE2000_BASE

Thanks.  I often rebuild the whitelist and resync defconfigs, and don't
post that.  One of those is also testing now (I caught the driver since
I rebuilt the whitelist, saw CONFIG_DRIVER_NE2000_BASE go away and
wondered what else could go).

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH] net: Remove ne2000 driver

2021-05-25 Thread Daniel Schwierzeck
Am Dienstag, den 25.05.2021, 11:54 -0400 schrieb Tom Rini:
> With the last user of this driver removed, remove the driver.
> 
> Signed-off-by: Tom Rini 
> ---
>  doc/README.ne2000 |  27 --
>  drivers/net/8390.h| 124 --
>  drivers/net/Makefile  |   1 -
>  drivers/net/ne2000.c  | 260 -
>  drivers/net/ne2000.h  |  94 -
>  drivers/net/ne2000_base.c | 792 
> --
>  drivers/net/ne2000_base.h | 305 ---
>  7 files changed, 1603 deletions(-)
>  delete mode 100644 doc/README.ne2000
>  delete mode 100644 drivers/net/8390.h
>  delete mode 100644 drivers/net/ne2000.c
>  delete mode 100644 drivers/net/ne2000.h
>  delete mode 100644 drivers/net/ne2000_base.c
>  delete mode 100644 drivers/net/ne2000_base.h

Reviewed-by: Daniel Schwierzeck 


There are still some references in config_whitelist.txt:

$ git grep -in ne2000 -- scripts/config_whitelist.txt
scripts/config_whitelist.txt:303:CONFIG_DRIVER_NE2000
scripts/config_whitelist.txt:304:CONFIG_DRIVER_NE2000_BASE

-- 
- Daniel



[PATCH] net: Remove ne2000 driver

2021-05-25 Thread Tom Rini
With the last user of this driver removed, remove the driver.

Signed-off-by: Tom Rini 
---
 doc/README.ne2000 |  27 --
 drivers/net/8390.h| 124 --
 drivers/net/Makefile  |   1 -
 drivers/net/ne2000.c  | 260 -
 drivers/net/ne2000.h  |  94 -
 drivers/net/ne2000_base.c | 792 --
 drivers/net/ne2000_base.h | 305 ---
 7 files changed, 1603 deletions(-)
 delete mode 100644 doc/README.ne2000
 delete mode 100644 drivers/net/8390.h
 delete mode 100644 drivers/net/ne2000.c
 delete mode 100644 drivers/net/ne2000.h
 delete mode 100644 drivers/net/ne2000_base.c
 delete mode 100644 drivers/net/ne2000_base.h

diff --git a/doc/README.ne2000 b/doc/README.ne2000
deleted file mode 100644
index 0f6a2e04ff1c..
--- a/doc/README.ne2000
+++ /dev/null
@@ -1,27 +0,0 @@
-This driver supports NE2000 compatible cards (those based on DP8390,
-DP83902 and similar). It can be used with PCMCIA/CF cards provided
-that the CCR is correctly initialized.
-
-The code is based on sources from the Linux kernel (pcnet_cs.c,
-8390.h) and eCOS(if_dp83902a.c, if_dp83902a.h). Both of these 2
-wonderful world are GPL, so this is, of course, GPL.
-
-I developed and tested this driver on a custom PXA255 based system and
-with a billionton CF network card connected to the PCMCIA interface of
-the micro (have a look at README.PXA_CF for the support of this port).
-
-The options you have to specify in the config file are (with the
-value for my board as an example):
-
-#define CONFIG_DRIVER_NE2000
-
-- Enables the driver
-
-#define CONFIG_DRIVER_NE2000_BASE (0x2000+0x300)
-
-- Address where the board is mapped
-
-
-Enjoy!
-
-Christian Pellegrin 
diff --git a/drivers/net/8390.h b/drivers/net/8390.h
deleted file mode 100644
index f087217ed00a..
--- a/drivers/net/8390.h
+++ /dev/null
@@ -1,124 +0,0 @@
-/*
-
-Ported to U-Boot  by Christian Pellegrin 
-
-Based on sources from the Linux kernel (pcnet_cs.c, 8390.h) and
-eCOS(if_dp83902a.c, if_dp83902a.h). Both of these 2 wonderful world
-are GPL, so this is, of course, GPL.
-
-*/
-
-/* Generic NS8390 register definitions. */
-/* This file is part of Donald Becker's 8390 drivers, and is distributed
-   under the same license. Auto-loading of 8390.o only in v2.2 - Paul G.
-   Some of these names and comments originated from the Crynwr
-   packet drivers, which are distributed under the GPL. */
-
-#ifndef _8390_h
-#define _8390_h
-
-/* Some generic ethernet register configurations. */
-#define E8390_TX_IRQ_MASK  0xa /* For register EN0_ISR */
-#define E8390_RX_IRQ_MASK  0x5
-#define E8390_RXCONFIG 0x4 /* EN0_RXCR: broadcasts, no 
multicast,errors */
-#define E8390_RXOFF0x20/* EN0_RXCR: Accept no packets */
-#define E8390_TXCONFIG 0x00/* EN0_TXCR: Normal transmit mode */
-#define E8390_TXOFF0x02/* EN0_TXCR: Transmitter off */
-
-/*  Register accessed at EN_CMD, the 8390 base addr.  */
-#define E8390_STOP 0x01/* Stop and reset the chip */
-#define E8390_START0x02/* Start the chip, clear reset */
-#define E8390_TRANS0x04/* Transmit a frame */
-#define E8390_RREAD0x08/* Remote read */
-#define E8390_RWRITE   0x10/* Remote write  */
-#define E8390_NODMA0x20/* Remote DMA */
-#define E8390_PAGE00x00/* Select page chip registers */
-#define E8390_PAGE10x40/* using the two high-order bits */
-#define E8390_PAGE20x80/* Page 3 is invalid. */
-
-/*
- * Only generate indirect loads given a machine that needs them.
- *  - removed AMIGA_PCMCIA from this list, handled as ISA io now
- */
-
-#define n2k_inb(port)   (*((volatile unsigned char 
*)(port+CONFIG_DRIVER_NE2000_BASE)))
-#define n2k_outb(val,port)  (*((volatile unsigned char 
*)(port+CONFIG_DRIVER_NE2000_BASE)) = val)
-
-#define EI_SHIFT(x)(x)
-
-#define E8390_CMD  EI_SHIFT(0x00)  /* The command register (for all pages) 
*/
-/* Page 0 register offsets. */
-#define EN0_CLDALO EI_SHIFT(0x01)  /* Low byte of current local dma addr  
RD */
-#define EN0_STARTPGEI_SHIFT(0x01)  /* Starting page of ring bfr WR */
-#define EN0_CLDAHI EI_SHIFT(0x02)  /* High byte of current local dma addr  
RD */
-#define EN0_STOPPG EI_SHIFT(0x02)  /* Ending page +1 of ring bfr WR */
-#define EN0_BOUNDARY   EI_SHIFT(0x03)  /* Boundary page of ring bfr RD WR */
-#define EN0_TSREI_SHIFT(0x04)  /* Transmit status reg RD */
-#define EN0_TPSR   EI_SHIFT(0x04)  /* Transmit starting page WR */
-#define EN0_NCREI_SHIFT(0x05)  /* Number of collision reg RD */
-#define EN0_TCNTLO EI_SHIFT(0x05)  /* Low  byte of tx byte count WR */
-#define EN0_FIFO   EI_SHIFT(0x06)  /* FIFO RD */
-#define EN0_TCNTHI EI_SHIFT(0x06)  /* High byte of tx byte count WR */
-#define EN0_ISREI_SHIFT(0x07)  /* Interrupt status reg RD WR */
-#define EN0_CRDALO EI_SHIFT(0x08)  /* low