Re: [PATCH] net: phy: genphy_init can be static

[Ramon Fried]

On Sat, Sep 18, 2021 at 3:09 PM Bin Meng  wrote:
>
> On Sat, Sep 18, 2021 at 7:55 PM Vladimir Oltean  
> wrote:
> >
> > To avoid a warning with W=1 about this function not having a previous
> > prototype, declare it as static, because it is not used outside of this
> > translation module.
> >
> > Signed-off-by: Vladimir Oltean 
> > ---
> >  drivers/net/phy/phy.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng 
Reviewed-by: Ramon Fried 

Re: [PATCH] net: phy: genphy_init can be static

[Bin Meng]

On Sat, Sep 18, 2021 at 7:55 PM Vladimir Oltean  wrote:
>
> To avoid a warning with W=1 about this function not having a previous
> prototype, declare it as static, because it is not used outside of this
> translation module.
>
> Signed-off-by: Vladimir Oltean 
> ---
>  drivers/net/phy/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng 

[PATCH] net: phy: genphy_init can be static

[Vladimir Oltean]

To avoid a warning with W=1 about this function not having a previous
prototype, declare it as static, because it is not used outside of this
translation module.

Signed-off-by: Vladimir Oltean 
---
 drivers/net/phy/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 69acb6946061..c9fc20855ba1 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -463,7 +463,7 @@ static struct phy_driver genphy_driver = {
.shutdown   = genphy_shutdown,
 };
 
-int genphy_init(void)
+static int genphy_init(void)
 {
return phy_register(_driver);
 }
-- 
2.25.1