[PATCH] tools: imx8mimage: Keep IVT reserved1 field zero always

2022-07-25 Thread sbabic
> Since fe8acf556c3 ("imx: HAB: Validate IVT before authenticating image")
> the U-Boot HAB implementation is checking whether reserved1 field in IVT
> is zero or not. In case the field is not zero, IVT validation fails. Stop
> setting IVT reserved1 field to non-zero in mkimage imx8m plugin, otherwise
> the validation cannot ever work.
> Note that this only affects legacy boards which do not use binman.
> Signed-off-by: Marek Vasut 
> Cc: Fabio Estevam 
> Cc: Peng Fan 
> Cc: Stefano Babic 
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=


[PATCH] tools: imx8mimage: Keep IVT reserved1 field zero always

2022-06-29 Thread Marek Vasut
Since fe8acf556c3 ("imx: HAB: Validate IVT before authenticating image")
the U-Boot HAB implementation is checking whether reserved1 field in IVT
is zero or not. In case the field is not zero, IVT validation fails. Stop
setting IVT reserved1 field to non-zero in mkimage imx8m plugin, otherwise
the validation cannot ever work.

Note that this only affects legacy boards which do not use binman.

Signed-off-by: Marek Vasut 
Cc: Fabio Estevam 
Cc: Peng Fan 
Cc: Stefano Babic 
---
 tools/imx8mimage.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
index 4eed683396f..52baf4c9903 100644
--- a/tools/imx8mimage.c
+++ b/tools/imx8mimage.c
@@ -505,14 +505,6 @@ void build_image(int ofd)
exit(EXIT_FAILURE);
} else {
sld_header_off = sld_src_off - rom_image_offset;
-   /*
-* Record the second bootloader relative offset in
-* image's IVT reserved1
-*/
-   if (rom_version == ROM_V1) {
-   imx_header[IMAGE_IVT_ID].fhdr.reserved1 =
-   sld_header_off - header_image_off;
-   }
sld_fd = open(sld_img, O_RDONLY | O_BINARY);
if (sld_fd < 0) {
fprintf(stderr, "%s: Can't open: %s\n",
-- 
2.35.1