Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-30 Thread Kever Yang
Hi, On 2020/10/16 上午2:29, Tom Rini wrote: On Wed, Oct 14, 2020 at 11:39:40PM +0300, Alper Nebi Yasak wrote: On 14/10/2020 22:31, Tom Rini wrote: On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: On 14/10/2020 18:24, Tom Rini wrote: Ugh. In so far as anything can be re-licens

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-30 Thread Kever Yang
On 2020/10/7 上午4:39, Alper Nebi Yasak wrote: Found this by comparing it to the coreboot driver, a form of this call was introduced there in their commit b9a7877568cf ("rockchip/*: refactor edp driver"). This is copy-pasted from U-Boot's link_train_cr() slightly above it. Without this on a gru-

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-15 Thread Tom Rini
On Wed, Oct 14, 2020 at 11:39:40PM +0300, Alper Nebi Yasak wrote: > On 14/10/2020 22:31, Tom Rini wrote: > > On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: > >> On 14/10/2020 18:24, Tom Rini wrote: > >>> Ugh. In so far as anything can be re-licensed, who did it all > >>> origina

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-15 Thread Alper Nebi Yasak
On 15/10/2020 10:19, Arnaud Patard (Rtp) wrote: > Alper Nebi Yasak writes: >> I'm not sure re-porting is a great idea from the technical perspective. >> I've been reading both drivers to compare them, there are also things in >> U-Boot that're missing from coreboot. Things like DM integration are

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-15 Thread Rtp
Alper Nebi Yasak writes: > On 14/10/2020 22:31, Tom Rini wrote: >> On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: >>> On 14/10/2020 18:24, Tom Rini wrote: Ugh. In so far as anything can be re-licensed, who did it all originally? I suspect coreboot isn't interested i

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Alper Nebi Yasak
On 14/10/2020 22:31, Tom Rini wrote: > On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: >> On 14/10/2020 18:24, Tom Rini wrote: >>> Ugh. In so far as anything can be re-licensed, who did it all >>> originally? I suspect coreboot isn't interested in 2.0+ but we can do >>> 2.0-only

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Tom Rini
On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: > On 14/10/2020 18:24, Tom Rini wrote: > > On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote: > >> I think it is OK to change the file to GPL2. I'm not sure if changing > >> coreboot parts to 2.0+ is an option. I believe th

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Simon Glass
Hi, On Wed, 14 Oct 2020 at 09:24, Tom Rini wrote: > > On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote: > > Hi Alper, > > > > On Tue, 13 Oct 2020 at 09:01, Alper Nebi Yasak > > wrote: > > > > > > On 12/10/2020 06:34, Simon Glass wrote: > > > > On Tue, 6 Oct 2020 at 14:40, Alper Nebi

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Alper Nebi Yasak
On 14/10/2020 18:24, Tom Rini wrote: > On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote: >> I think it is OK to change the file to GPL2. I'm not sure if changing >> coreboot parts to 2.0+ is an option. I believe the use of 2+ in U-Boot >> is for fairly narrow reasons, but I'm not sure if

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Tom Rini
On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote: > Hi Alper, > > On Tue, 13 Oct 2020 at 09:01, Alper Nebi Yasak > wrote: > > > > On 12/10/2020 06:34, Simon Glass wrote: > > > On Tue, 6 Oct 2020 at 14:40, Alper Nebi Yasak > > > wrote: > > >> > > >> Found this by comparing it to the

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-13 Thread Simon Glass
Hi Alper, On Tue, 13 Oct 2020 at 09:01, Alper Nebi Yasak wrote: > > On 12/10/2020 06:34, Simon Glass wrote: > > On Tue, 6 Oct 2020 at 14:40, Alper Nebi Yasak > > wrote: > >> > >> Found this by comparing it to the coreboot driver, a form of this call > >> was introduced there in their commit b9a

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-13 Thread Alper Nebi Yasak
On 12/10/2020 06:34, Simon Glass wrote: > On Tue, 6 Oct 2020 at 14:40, Alper Nebi Yasak > wrote: >> >> Found this by comparing it to the coreboot driver, a form of this call >> was introduced there in their commit b9a7877568cf ("rockchip/*: refactor >> edp driver"). This is copy-pasted from U-Boo

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-11 Thread Simon Glass
On Tue, 6 Oct 2020 at 14:40, Alper Nebi Yasak wrote: > > Found this by comparing it to the coreboot driver, a form of this call > was introduced there in their commit b9a7877568cf ("rockchip/*: refactor > edp driver"). This is copy-pasted from U-Boot's link_train_cr() slightly > above it. > > With

[PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-06 Thread Alper Nebi Yasak
Found this by comparing it to the coreboot driver, a form of this call was introduced there in their commit b9a7877568cf ("rockchip/*: refactor edp driver"). This is copy-pasted from U-Boot's link_train_cr() slightly above it. Without this on a gru-kevin chromebook, I have: clock recovery at