Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi Neil, On Thu, 2 Jul 2020 at 13:29, Neil Armstrong wrote: > > On 01/07/2020 18:09, Anand Moon wrote: > > Hi Neil, > > > > On Wed, 1 Jul 2020 at 20:16, Neil Armstrong wrote: > >> > >> On 01/07/2020 16:43, Anand Moon wrote: > >>> Hi Neil, > >>> > >>> On Wed, 1 Jul 2020 at 18:38, Neil Armstrong > >>> wrote: > > Hi, > > On 01/07/2020 13:31, Anand Moon wrote: > > Hi Neil, > > > > On Wed, 1 Jul 2020 at 13:22, Neil Armstrong > > wrote: > >> > >> Hi, > >> > >> On 30/06/2020 18:02, Anand Moon wrote: > >>> Hi Neil, > >>> > >>> On Tue, 30 Jun 2020 at 18:30, Neil Armstrong > >>> wrote: > > Hi, > > On 30/06/2020 13:33, Anand Moon wrote: > > Hi Beniamino, > > > > On Wed, 6 May 2020 at 01:53, Beniamino Galvani > > wrote: > >> > >> Hi, > >> > >> these two patches add initial u-boot support for Hardkernel > >> ODROID-C4. > >> > >> https://wiki.odroid.com/odroid-c4/odroid-c4 > >> > >> Beniamino Galvani (2): > >> arm: dts: import ODROID-C4 device tree > >> boards: amlogic: add ODROID-C4 support > >> > > > > Can you respin this patches, I would like to see these get merged in > > the current u-boot release > > > > -Anand > > > > The Odroid-C4 could re-use the new Odroid-N2 board support I > submitted at [1] > > Anand, is the MAC address stored stored the same way on the C4 ? > > Neil > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > >>> > >>> I gave this patches a try on latest u-boot but I cannot make my Odroid > >>> C4 to boot up uinsg microSD card and eMMC > >>> Here are the logs. > >> > >> The PHY config must be wrong and it misses the -u-boot.dtsi to enable > >> HDMI. > >> > >> Can you test my custodian test branch with my C4 support patchset ? > >> > >> https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test > >> > >> This one is used in Armbian 5.4 release and our KernelCI lab. > >> > >> Neil > >> > > > > Thanks. > > > > There seems to be a typo in the build instructions in # > > doc/board/amlogic/odroid-c4.rst > > instead of *g12b*, it should be *g12a* > > > > See below I get following build warning, which I fix locally, > > > > ./buildc4c.sh: line 78: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 81: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 84: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 87: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 90: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 92: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > > > After that fix I am able to boot my board using eMMC and microSD card. > > Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this > typo. > > Neil > > >>> > >>> Thanks, I see the same issue with random mac address just like N2. > >> > >> Yes, my branch was not using the N2 board support with eFuses MAC readout, > >> can you test my last patchset I just sent ? It should use the MAC from > >> eFuses or > >> generate an unique address with the SoC serial number. > >> > > Thanks > > > >> Please apply the patch in [1] before the new Odroid-C4 serie. > >> > >> [1] > >> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > >> > >> Neil > > > > I do not know the reason but your patches are not showing up on u-boot > > patchwork. > > > > [0] https://patchwork.ozlabs.org/project/uboot/list/ > > Good question ! > > Neil > Now it's showing up on u-boot patchwork. https://patchwork.ozlabs.org/project/uboot/list/?series=187096 -Anand
Re: [PATCH 0/2] u-boot support for ODROID-C4
On 01/07/2020 18:09, Anand Moon wrote: > Hi Neil, > > On Wed, 1 Jul 2020 at 20:16, Neil Armstrong wrote: >> >> On 01/07/2020 16:43, Anand Moon wrote: >>> Hi Neil, >>> >>> On Wed, 1 Jul 2020 at 18:38, Neil Armstrong wrote: Hi, On 01/07/2020 13:31, Anand Moon wrote: > Hi Neil, > > On Wed, 1 Jul 2020 at 13:22, Neil Armstrong > wrote: >> >> Hi, >> >> On 30/06/2020 18:02, Anand Moon wrote: >>> Hi Neil, >>> >>> On Tue, 30 Jun 2020 at 18:30, Neil Armstrong >>> wrote: Hi, On 30/06/2020 13:33, Anand Moon wrote: > Hi Beniamino, > > On Wed, 6 May 2020 at 01:53, Beniamino Galvani > wrote: >> >> Hi, >> >> these two patches add initial u-boot support for Hardkernel >> ODROID-C4. >> >> https://wiki.odroid.com/odroid-c4/odroid-c4 >> >> Beniamino Galvani (2): >> arm: dts: import ODROID-C4 device tree >> boards: amlogic: add ODROID-C4 support >> > > Can you respin this patches, I would like to see these get merged in > the current u-boot release > > -Anand > The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1] Anand, is the MAC address stored stored the same way on the C4 ? Neil [1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ >>> >>> I gave this patches a try on latest u-boot but I cannot make my Odroid >>> C4 to boot up uinsg microSD card and eMMC >>> Here are the logs. >> >> The PHY config must be wrong and it misses the -u-boot.dtsi to enable >> HDMI. >> >> Can you test my custodian test branch with my C4 support patchset ? >> >> https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test >> >> This one is used in Armbian 5.4 release and our KernelCI lab. >> >> Neil >> > > Thanks. > > There seems to be a typo in the build instructions in # > doc/board/amlogic/odroid-c4.rst > instead of *g12b*, it should be *g12a* > > See below I get following build warning, which I fix locally, > > ./buildc4c.sh: line 78: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 81: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 84: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 87: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 90: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 92: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > > After that fix I am able to boot my board using eMMC and microSD card. Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo. Neil >>> >>> Thanks, I see the same issue with random mac address just like N2. >> >> Yes, my branch was not using the N2 board support with eFuses MAC readout, >> can you test my last patchset I just sent ? It should use the MAC from >> eFuses or >> generate an unique address with the SoC serial number. >> > Thanks > >> Please apply the patch in [1] before the new Odroid-C4 serie. >> >> [1] >> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ >> >> Neil > > I do not know the reason but your patches are not showing up on u-boot > patchwork. > > [0] https://patchwork.ozlabs.org/project/uboot/list/ Good question ! Neil > > -Anand >
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi Neil, On Wed, 1 Jul 2020 at 20:16, Neil Armstrong wrote: > > On 01/07/2020 16:43, Anand Moon wrote: > > Hi Neil, > > > > On Wed, 1 Jul 2020 at 18:38, Neil Armstrong wrote: > >> > >> Hi, > >> > >> On 01/07/2020 13:31, Anand Moon wrote: > >>> Hi Neil, > >>> > >>> On Wed, 1 Jul 2020 at 13:22, Neil Armstrong > >>> wrote: > > Hi, > > On 30/06/2020 18:02, Anand Moon wrote: > > Hi Neil, > > > > On Tue, 30 Jun 2020 at 18:30, Neil Armstrong > > wrote: > >> > >> Hi, > >> > >> On 30/06/2020 13:33, Anand Moon wrote: > >>> Hi Beniamino, > >>> > >>> On Wed, 6 May 2020 at 01:53, Beniamino Galvani > >>> wrote: > > Hi, > > these two patches add initial u-boot support for Hardkernel > ODROID-C4. > > https://wiki.odroid.com/odroid-c4/odroid-c4 > > Beniamino Galvani (2): > arm: dts: import ODROID-C4 device tree > boards: amlogic: add ODROID-C4 support > > >>> > >>> Can you respin this patches, I would like to see these get merged in > >>> the current u-boot release > >>> > >>> -Anand > >>> > >> > >> The Odroid-C4 could re-use the new Odroid-N2 board support I submitted > >> at [1] > >> > >> Anand, is the MAC address stored stored the same way on the C4 ? > >> > >> Neil > >> > >> [1] > >> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > > > > I gave this patches a try on latest u-boot but I cannot make my Odroid > > C4 to boot up uinsg microSD card and eMMC > > Here are the logs. > > The PHY config must be wrong and it misses the -u-boot.dtsi to enable > HDMI. > > Can you test my custodian test branch with my C4 support patchset ? > > https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test > > This one is used in Armbian 5.4 release and our KernelCI lab. > > Neil > > >>> > >>> Thanks. > >>> > >>> There seems to be a typo in the build instructions in # > >>> doc/board/amlogic/odroid-c4.rst > >>> instead of *g12b*, it should be *g12a* > >>> > >>> See below I get following build warning, which I fix locally, > >>> > >>> ./buildc4c.sh: line 78: > >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>> No such file or directory > >>> ./buildc4c.sh: line 81: > >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>> No such file or directory > >>> ./buildc4c.sh: line 84: > >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>> No such file or directory > >>> ./buildc4c.sh: line 87: > >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>> No such file or directory > >>> ./buildc4c.sh: line 90: > >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>> No such file or directory > >>> ./buildc4c.sh: line 92: > >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>> No such file or directory > >>> > >>> After that fix I am able to boot my board using eMMC and microSD card. > >> > >> Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this > >> typo. > >> > >> Neil > >> > > > > Thanks, I see the same issue with random mac address just like N2. > > Yes, my branch was not using the N2 board support with eFuses MAC readout, > can you test my last patchset I just sent ? It should use the MAC from eFuses > or > generate an unique address with the SoC serial number. > Thanks > Please apply the patch in [1] before the new Odroid-C4 serie. > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > > Neil I do not know the reason but your patches are not showing up on u-boot patchwork. [0] https://patchwork.ozlabs.org/project/uboot/list/ -Anand
Re: [PATCH 0/2] u-boot support for ODROID-C4
On 01/07/2020 16:43, Anand Moon wrote: > Hi Neil, > > On Wed, 1 Jul 2020 at 18:38, Neil Armstrong wrote: >> >> Hi, >> >> On 01/07/2020 13:31, Anand Moon wrote: >>> Hi Neil, >>> >>> On Wed, 1 Jul 2020 at 13:22, Neil Armstrong wrote: Hi, On 30/06/2020 18:02, Anand Moon wrote: > Hi Neil, > > On Tue, 30 Jun 2020 at 18:30, Neil Armstrong > wrote: >> >> Hi, >> >> On 30/06/2020 13:33, Anand Moon wrote: >>> Hi Beniamino, >>> >>> On Wed, 6 May 2020 at 01:53, Beniamino Galvani >>> wrote: Hi, these two patches add initial u-boot support for Hardkernel ODROID-C4. https://wiki.odroid.com/odroid-c4/odroid-c4 Beniamino Galvani (2): arm: dts: import ODROID-C4 device tree boards: amlogic: add ODROID-C4 support >>> >>> Can you respin this patches, I would like to see these get merged in >>> the current u-boot release >>> >>> -Anand >>> >> >> The Odroid-C4 could re-use the new Odroid-N2 board support I submitted >> at [1] >> >> Anand, is the MAC address stored stored the same way on the C4 ? >> >> Neil >> >> [1] >> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > > I gave this patches a try on latest u-boot but I cannot make my Odroid > C4 to boot up uinsg microSD card and eMMC > Here are the logs. The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI. Can you test my custodian test branch with my C4 support patchset ? https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test This one is used in Armbian 5.4 release and our KernelCI lab. Neil >>> >>> Thanks. >>> >>> There seems to be a typo in the build instructions in # >>> doc/board/amlogic/odroid-c4.rst >>> instead of *g12b*, it should be *g12a* >>> >>> See below I get following build warning, which I fix locally, >>> >>> ./buildc4c.sh: line 78: >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: >>> No such file or directory >>> ./buildc4c.sh: line 81: >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: >>> No such file or directory >>> ./buildc4c.sh: line 84: >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: >>> No such file or directory >>> ./buildc4c.sh: line 87: >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: >>> No such file or directory >>> ./buildc4c.sh: line 90: >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: >>> No such file or directory >>> ./buildc4c.sh: line 92: >>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: >>> No such file or directory >>> >>> After that fix I am able to boot my board using eMMC and microSD card. >> >> Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo. >> >> Neil >> > > Thanks, I see the same issue with random mac address just like N2. Yes, my branch was not using the N2 board support with eFuses MAC readout, can you test my last patchset I just sent ? It should use the MAC from eFuses or generate an unique address with the SoC serial number. Please apply the patch in [1] before the new Odroid-C4 serie. [1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ Neil > > -Anand >
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi, On 01/07/2020 13:31, Anand Moon wrote: > Hi Neil, > > On Wed, 1 Jul 2020 at 13:22, Neil Armstrong wrote: >> >> Hi, >> >> On 30/06/2020 18:02, Anand Moon wrote: >>> Hi Neil, >>> >>> On Tue, 30 Jun 2020 at 18:30, Neil Armstrong >>> wrote: Hi, On 30/06/2020 13:33, Anand Moon wrote: > Hi Beniamino, > > On Wed, 6 May 2020 at 01:53, Beniamino Galvani > wrote: >> >> Hi, >> >> these two patches add initial u-boot support for Hardkernel ODROID-C4. >> >> https://wiki.odroid.com/odroid-c4/odroid-c4 >> >> Beniamino Galvani (2): >> arm: dts: import ODROID-C4 device tree >> boards: amlogic: add ODROID-C4 support >> > > Can you respin this patches, I would like to see these get merged in > the current u-boot release > > -Anand > The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1] Anand, is the MAC address stored stored the same way on the C4 ? Neil [1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ >>> >>> I gave this patches a try on latest u-boot but I cannot make my Odroid >>> C4 to boot up uinsg microSD card and eMMC >>> Here are the logs. >> >> The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI. >> >> Can you test my custodian test branch with my C4 support patchset ? >> >> https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test >> >> This one is used in Armbian 5.4 release and our KernelCI lab. >> >> Neil >> > > Thanks. > > There seems to be a typo in the build instructions in # > doc/board/amlogic/odroid-c4.rst > instead of *g12b*, it should be *g12a* > > See below I get following build warning, which I fix locally, > > ./buildc4c.sh: line 78: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 81: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 84: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 87: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 90: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > ./buildc4c.sh: line 92: > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > No such file or directory > > After that fix I am able to boot my board using eMMC and microSD card. Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo. Neil > > -Anand >
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi Neil, On Wed, 1 Jul 2020 at 18:38, Neil Armstrong wrote: > > Hi, > > On 01/07/2020 13:31, Anand Moon wrote: > > Hi Neil, > > > > On Wed, 1 Jul 2020 at 13:22, Neil Armstrong wrote: > >> > >> Hi, > >> > >> On 30/06/2020 18:02, Anand Moon wrote: > >>> Hi Neil, > >>> > >>> On Tue, 30 Jun 2020 at 18:30, Neil Armstrong > >>> wrote: > > Hi, > > On 30/06/2020 13:33, Anand Moon wrote: > > Hi Beniamino, > > > > On Wed, 6 May 2020 at 01:53, Beniamino Galvani > > wrote: > >> > >> Hi, > >> > >> these two patches add initial u-boot support for Hardkernel ODROID-C4. > >> > >> https://wiki.odroid.com/odroid-c4/odroid-c4 > >> > >> Beniamino Galvani (2): > >> arm: dts: import ODROID-C4 device tree > >> boards: amlogic: add ODROID-C4 support > >> > > > > Can you respin this patches, I would like to see these get merged in > > the current u-boot release > > > > -Anand > > > > The Odroid-C4 could re-use the new Odroid-N2 board support I submitted > at [1] > > Anand, is the MAC address stored stored the same way on the C4 ? > > Neil > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > >>> > >>> I gave this patches a try on latest u-boot but I cannot make my Odroid > >>> C4 to boot up uinsg microSD card and eMMC > >>> Here are the logs. > >> > >> The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI. > >> > >> Can you test my custodian test branch with my C4 support patchset ? > >> > >> https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test > >> > >> This one is used in Armbian 5.4 release and our KernelCI lab. > >> > >> Neil > >> > > > > Thanks. > > > > There seems to be a typo in the build instructions in # > > doc/board/amlogic/odroid-c4.rst > > instead of *g12b*, it should be *g12a* > > > > See below I get following build warning, which I fix locally, > > > > ./buildc4c.sh: line 78: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 81: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 84: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 87: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 90: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > ./buildc4c.sh: line 92: > > /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > > No such file or directory > > > > After that fix I am able to boot my board using eMMC and microSD card. > > Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this typo. > > Neil > Thanks, I see the same issue with random mac address just like N2. -Anand
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi Neil, On Wed, 1 Jul 2020 at 13:22, Neil Armstrong wrote: > > Hi, > > On 30/06/2020 18:02, Anand Moon wrote: > > Hi Neil, > > > > On Tue, 30 Jun 2020 at 18:30, Neil Armstrong > > wrote: > >> > >> Hi, > >> > >> On 30/06/2020 13:33, Anand Moon wrote: > >>> Hi Beniamino, > >>> > >>> On Wed, 6 May 2020 at 01:53, Beniamino Galvani > >>> wrote: > > Hi, > > these two patches add initial u-boot support for Hardkernel ODROID-C4. > > https://wiki.odroid.com/odroid-c4/odroid-c4 > > Beniamino Galvani (2): > arm: dts: import ODROID-C4 device tree > boards: amlogic: add ODROID-C4 support > > >>> > >>> Can you respin this patches, I would like to see these get merged in > >>> the current u-boot release > >>> > >>> -Anand > >>> > >> > >> The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at > >> [1] > >> > >> Anand, is the MAC address stored stored the same way on the C4 ? > >> > >> Neil > >> > >> [1] > >> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > > > > I gave this patches a try on latest u-boot but I cannot make my Odroid > > C4 to boot up uinsg microSD card and eMMC > > Here are the logs. > > The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI. > > Can you test my custodian test branch with my C4 support patchset ? > > https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test > > This one is used in Armbian 5.4 release and our KernelCI lab. > > Neil > Thanks. There seems to be a typo in the build instructions in # doc/board/amlogic/odroid-c4.rst instead of *g12b*, it should be *g12a* See below I get following build warning, which I fix locally, ./buildc4c.sh: line 78: /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: No such file or directory ./buildc4c.sh: line 81: /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: No such file or directory ./buildc4c.sh: line 84: /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: No such file or directory ./buildc4c.sh: line 87: /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: No such file or directory ./buildc4c.sh: line 90: /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: No such file or directory ./buildc4c.sh: line 92: /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: No such file or directory After that fix I am able to boot my board using eMMC and microSD card. -Anand
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi, On 30/06/2020 18:02, Anand Moon wrote: > Hi Neil, > > On Tue, 30 Jun 2020 at 18:30, Neil Armstrong wrote: >> >> Hi, >> >> On 30/06/2020 13:33, Anand Moon wrote: >>> Hi Beniamino, >>> >>> On Wed, 6 May 2020 at 01:53, Beniamino Galvani wrote: Hi, these two patches add initial u-boot support for Hardkernel ODROID-C4. https://wiki.odroid.com/odroid-c4/odroid-c4 Beniamino Galvani (2): arm: dts: import ODROID-C4 device tree boards: amlogic: add ODROID-C4 support >>> >>> Can you respin this patches, I would like to see these get merged in >>> the current u-boot release >>> >>> -Anand >>> >> >> The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1] >> >> Anand, is the MAC address stored stored the same way on the C4 ? >> >> Neil >> >> [1] >> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > > I gave this patches a try on latest u-boot but I cannot make my Odroid > C4 to boot up uinsg microSD card and eMMC > Here are the logs. The PHY config must be wrong and it misses the -u-boot.dtsi to enable HDMI. Can you test my custodian test branch with my C4 support patchset ? https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test This one is used in Armbian 5.4 release and our KernelCI lab. Neil > > SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:F;RCY:0;EMMC:800;NAND:81;SD?:0;SD:0;READ:0;0.0;CHK:0; > bl2_stage_init 0x01 > bl2_stage_init 0x81 > hw id: 0x - pwm id 0x01 > bl2_stage_init 0xc1 > bl2_stage_init 0x02 > > no sdio debug board detected > L0: > L1:0703 > L2:8067 > L3:1520 > S1: > B2:20282000 > B1:a0f83180 > > TE: 260148 > > BL2 Built : 22:54:32, Apr 28 2020. g12a ga659aac-dirty - changqing.gao@droid11 > > Board ID = 1 > Set cpu clk to 24M > Set clk81 to 24M > Use GP1_pll as DSU clk. > DSU clk: 1200 Mhz > CPU clk: 1200 MHz > Set clk81 to 166.6M > DDR driver_vesion: LPDDR4_PHY_V_0_1_15 build time: Apr 28 2020 22:54:28 > board id: 1 > Load FIP HDR from SD, src: 0x00010200, des: 0xfffd, size: > 0x4000, part: 0 > fw parse done > Load ddrfw from SD, src: 0x00030200, des: 0xfffd, size: 0xc000, part: > 0 > Load ddrfw from SD, src: 0x0002c200, des: 0xfffd, size: 0x4000, part: > 0 > PIEI prepare done > fastboot data load > fastboot data verify > verify result: 255 > Cfg max: 2, cur: 1. Board id: 255. Force loop cfg > DDR4 probe > ddr clk to 1320MHz > Load ddrfw from SD, src: 0x00014200, des: 0xfffd, size: 0xc000, part: > 0 > > dmc_version 0001 > Check phy result > INFO : End of initialization > INFO : End of read enable training > INFO : End of fine write leveling > INFO : End of read dq deskew training > INFO : End of MPR read delay center optimization > INFO : End of Write leveling coarse delay > INFO : End of write delay center optimization > INFO : End of read delay center optimization > INFO : End of max read latency training > INFO : Training has run successfully! > 1D training succeed > Load ddrfw from SD, src: 0x00020200, des: 0xfffd, size: 0xc000, part: > 0 > Check phy result > INFO : End of initialization > INFO : End of 2D read delay Voltage center optimization > INFO : End of 2D write delay Voltage center optimization > INFO : Training has run successfully! > > R0_RxClkDly_Margin==106 ps 9 > R0_TxDqDly_Margi==118 ps 10 > > > R1_RxClkDly_Margin==0 ps 0 > R1_TxDqDly_Margi==0 ps 0 > > dwc_ddrphy_apb_wr((0<<20)|(2<<16)|(0<<12)|(0xb0):0001 > > soc_vref_reg_value 0x 004e 004e 004e 004d 004f > 004e 004e 004f 004c 004d 004e 004c > 004c 004e 004f 004e 0050 004e 004d > 004e 004e 004c 004d 004d 004d 004f > 004f 004f 004d 004d 004d 004f > dram_vref_reg_value 0x 0021 > 2D training succeed > aml_ddr_fw_vesion: LPDDR4_PHY_V_0_1_15 build time: Jun 18 2019 20:29:43 > auto size-- 65535DDR cs0 size: 2048MB > DDR cs1 size: 2048MB > DMC_DDR_CTRL: 00700024DDR size: 3928MB > cs0 DataBus test pass > cs1 DataBus test pass > cs0 AddrBus test pass > cs1 AddrBus test pass > > non-sec scramble use zero key > ddr scramble enabled > > 100bdlr_step_size ps== 461 > result report > boot times 0Enable ddr reg access > Load FIP HDR from SD, src: 0x00010200, des: 0x0170, size: > 0x4000, part: 0 > Load BL3X from SD, src: 0x0003c200, des: 0x0172c000, size: 0x0009, part: 0 > 0.0;M3 CHK:0;cm4_sp_mode 0 > MVN_1=0x > MVN_2=0x > [Image: g12a_v1.1.3386-3b31431 2019-05-21 10:41:54 luan.yuan@droid15-sz] > OPS=0x10 > ring efuse init > 2b 0c 10 00 01 13 20 00 00 0f 36 30 43 57 50 50 > [0.017319 Inits done] > secure task start! > high task start! > low task start! > run into bl31 > NOTICE: BL31: v1.3(release):4fc40b1 > NOTICE: BL31: Built : 15:57:33, May 22 2019 > NOTICE: BL31: G12A normal boot! > NOTICE: BL31: BL33 decompress pass > ERROR:
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi Neil, On Tue, 30 Jun 2020 at 18:30, Neil Armstrong wrote: > > Hi, > > On 30/06/2020 13:33, Anand Moon wrote: > > Hi Beniamino, > > > > On Wed, 6 May 2020 at 01:53, Beniamino Galvani wrote: > >> > >> Hi, > >> > >> these two patches add initial u-boot support for Hardkernel ODROID-C4. > >> > >> https://wiki.odroid.com/odroid-c4/odroid-c4 > >> > >> Beniamino Galvani (2): > >> arm: dts: import ODROID-C4 device tree > >> boards: amlogic: add ODROID-C4 support > >> > > > > Can you respin this patches, I would like to see these get merged in > > the current u-boot release > > > > -Anand > > > > The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1] > > Anand, is the MAC address stored stored the same way on the C4 ? > > Neil > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ I gave this patches a try on latest u-boot but I cannot make my Odroid C4 to boot up uinsg microSD card and eMMC Here are the logs. SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:F;RCY:0;EMMC:800;NAND:81;SD?:0;SD:0;READ:0;0.0;CHK:0; bl2_stage_init 0x01 bl2_stage_init 0x81 hw id: 0x - pwm id 0x01 bl2_stage_init 0xc1 bl2_stage_init 0x02 no sdio debug board detected L0: L1:0703 L2:8067 L3:1520 S1: B2:20282000 B1:a0f83180 TE: 260148 BL2 Built : 22:54:32, Apr 28 2020. g12a ga659aac-dirty - changqing.gao@droid11 Board ID = 1 Set cpu clk to 24M Set clk81 to 24M Use GP1_pll as DSU clk. DSU clk: 1200 Mhz CPU clk: 1200 MHz Set clk81 to 166.6M DDR driver_vesion: LPDDR4_PHY_V_0_1_15 build time: Apr 28 2020 22:54:28 board id: 1 Load FIP HDR from SD, src: 0x00010200, des: 0xfffd, size: 0x4000, part: 0 fw parse done Load ddrfw from SD, src: 0x00030200, des: 0xfffd, size: 0xc000, part: 0 Load ddrfw from SD, src: 0x0002c200, des: 0xfffd, size: 0x4000, part: 0 PIEI prepare done fastboot data load fastboot data verify verify result: 255 Cfg max: 2, cur: 1. Board id: 255. Force loop cfg DDR4 probe ddr clk to 1320MHz Load ddrfw from SD, src: 0x00014200, des: 0xfffd, size: 0xc000, part: 0 dmc_version 0001 Check phy result INFO : End of initialization INFO : End of read enable training INFO : End of fine write leveling INFO : End of read dq deskew training INFO : End of MPR read delay center optimization INFO : End of Write leveling coarse delay INFO : End of write delay center optimization INFO : End of read delay center optimization INFO : End of max read latency training INFO : Training has run successfully! 1D training succeed Load ddrfw from SD, src: 0x00020200, des: 0xfffd, size: 0xc000, part: 0 Check phy result INFO : End of initialization INFO : End of 2D read delay Voltage center optimization INFO : End of 2D write delay Voltage center optimization INFO : Training has run successfully! R0_RxClkDly_Margin==106 ps 9 R0_TxDqDly_Margi==118 ps 10 R1_RxClkDly_Margin==0 ps 0 R1_TxDqDly_Margi==0 ps 0 dwc_ddrphy_apb_wr((0<<20)|(2<<16)|(0<<12)|(0xb0):0001 soc_vref_reg_value 0x 004e 004e 004e 004d 004f 004e 004e 004f 004c 004d 004e 004c 004c 004e 004f 004e 0050 004e 004d 004e 004e 004c 004d 004d 004d 004f 004f 004f 004d 004d 004d 004f dram_vref_reg_value 0x 0021 2D training succeed aml_ddr_fw_vesion: LPDDR4_PHY_V_0_1_15 build time: Jun 18 2019 20:29:43 auto size-- 65535DDR cs0 size: 2048MB DDR cs1 size: 2048MB DMC_DDR_CTRL: 00700024DDR size: 3928MB cs0 DataBus test pass cs1 DataBus test pass cs0 AddrBus test pass cs1 AddrBus test pass non-sec scramble use zero key ddr scramble enabled 100bdlr_step_size ps== 461 result report boot times 0Enable ddr reg access Load FIP HDR from SD, src: 0x00010200, des: 0x0170, size: 0x4000, part: 0 Load BL3X from SD, src: 0x0003c200, des: 0x0172c000, size: 0x0009, part: 0 0.0;M3 CHK:0;cm4_sp_mode 0 MVN_1=0x MVN_2=0x [Image: g12a_v1.1.3386-3b31431 2019-05-21 10:41:54 luan.yuan@droid15-sz] OPS=0x10 ring efuse init 2b 0c 10 00 01 13 20 00 00 0f 36 30 43 57 50 50 [0.017319 Inits done] secure task start! high task start! low task start! run into bl31 NOTICE: BL31: v1.3(release):4fc40b1 NOTICE: BL31: Built : 15:57:33, May 22 2019 NOTICE: BL31: G12A normal boot! NOTICE: BL31: BL33 decompress pass ERROR: Error initializing runtime service opteed_fast U-Boot 2020.07-rc5-00076-g46e5b60e21 (Jun 30 2020 - 21:08:25 +0530) odroid-c4 Model: Hardkernel ODROID-C4 SoC: Amlogic Meson SM1 (Unknown) Revision 2b:c (10:2) DRAM: 3.8 GiB MMC: sd@ffe05000: 0, mmc@ffe07000: 1 stdio_add_devices: Video device failed (ret=-22) In:serial@3000 Out: serial@3000 Err: serial@3000 Net: Could not get PHY for ethernet@ff3f: addr 8 No ethernet found. Hit any key to stop autoboot: 0 -Anand
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi, On 30/06/2020 13:33, Anand Moon wrote: > Hi Beniamino, > > On Wed, 6 May 2020 at 01:53, Beniamino Galvani wrote: >> >> Hi, >> >> these two patches add initial u-boot support for Hardkernel ODROID-C4. >> >> https://wiki.odroid.com/odroid-c4/odroid-c4 >> >> Beniamino Galvani (2): >> arm: dts: import ODROID-C4 device tree >> boards: amlogic: add ODROID-C4 support >> > > Can you respin this patches, I would like to see these get merged in > the current u-boot release > > -Anand > The Odroid-C4 could re-use the new Odroid-N2 board support I submitted at [1] Anand, is the MAC address stored stored the same way on the C4 ? Neil [1] https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi Beniamino, On Wed, 6 May 2020 at 01:53, Beniamino Galvani wrote: > > Hi, > > these two patches add initial u-boot support for Hardkernel ODROID-C4. > > https://wiki.odroid.com/odroid-c4/odroid-c4 > > Beniamino Galvani (2): > arm: dts: import ODROID-C4 device tree > boards: amlogic: add ODROID-C4 support > Can you respin this patches, I would like to see these get merged in the current u-boot release -Anand
Re: [PATCH 0/2] u-boot support for ODROID-C4
On Wed, May 06, 2020 at 09:59:17AM +0200, Neil Armstrong wrote: > Hi Beniamino, > > On 05/05/2020 22:22, Beniamino Galvani wrote: > > Hi, > > > > these two patches add initial u-boot support for Hardkernel ODROID-C4. > > Thanks for the patchset, I already have one in my test tree, by you did beat > me > by sending it to the list ! Oh, I didn't notice, sorry. > > https://wiki.odroid.com/odroid-c4/odroid-c4 > > > > Beniamino Galvani (2): > > arm: dts: import ODROID-C4 device tree > > The DT is not yet applied by kevin, thus I'll prefer waiting it to be accepted > and merged in a stable linux tree to keep DT synced. > > > boards: amlogic: add ODROID-C4 support > > Please re-use the w400 board instead of adding a new board, there is no need > for a new > one until you'll need to add more functionalities. > > I know meson_generate_serial_ethaddr() is absent from w400, I'll add it > shortly. Okay, I'll wait that the DT gets merged and then will resubmit using w400. Thanks, Beniamino
Re: [PATCH 0/2] u-boot support for ODROID-C4
Hi Beniamino, On 05/05/2020 22:22, Beniamino Galvani wrote: > Hi, > > these two patches add initial u-boot support for Hardkernel ODROID-C4. Thanks for the patchset, I already have one in my test tree, by you did beat me by sending it to the list ! > > https://wiki.odroid.com/odroid-c4/odroid-c4 > > Beniamino Galvani (2): > arm: dts: import ODROID-C4 device tree The DT is not yet applied by kevin, thus I'll prefer waiting it to be accepted and merged in a stable linux tree to keep DT synced. > boards: amlogic: add ODROID-C4 support Please re-use the w400 board instead of adding a new board, there is no need for a new one until you'll need to add more functionalities. I know meson_generate_serial_ethaddr() is absent from w400, I'll add it shortly. Neil > > arch/arm/dts/Makefile| 1 + > arch/arm/dts/meson-sm1-odroid-c4.dts | 399 +++ > board/amlogic/odroid-c4/MAINTAINERS | 6 + > board/amlogic/odroid-c4/Makefile | 3 + > board/amlogic/odroid-c4/README | 83 ++ > board/amlogic/odroid-c4/odroid-c4.c | 17 ++ > configs/odroid-c4_defconfig | 63 + > 7 files changed, 572 insertions(+) > create mode 100644 arch/arm/dts/meson-sm1-odroid-c4.dts > create mode 100644 board/amlogic/odroid-c4/MAINTAINERS > create mode 100644 board/amlogic/odroid-c4/Makefile > create mode 100644 board/amlogic/odroid-c4/README > create mode 100644 board/amlogic/odroid-c4/odroid-c4.c > create mode 100644 configs/odroid-c4_defconfig >
[PATCH 0/2] u-boot support for ODROID-C4
Hi, these two patches add initial u-boot support for Hardkernel ODROID-C4. https://wiki.odroid.com/odroid-c4/odroid-c4 Beniamino Galvani (2): arm: dts: import ODROID-C4 device tree boards: amlogic: add ODROID-C4 support arch/arm/dts/Makefile| 1 + arch/arm/dts/meson-sm1-odroid-c4.dts | 399 +++ board/amlogic/odroid-c4/MAINTAINERS | 6 + board/amlogic/odroid-c4/Makefile | 3 + board/amlogic/odroid-c4/README | 83 ++ board/amlogic/odroid-c4/odroid-c4.c | 17 ++ configs/odroid-c4_defconfig | 63 + 7 files changed, 572 insertions(+) create mode 100644 arch/arm/dts/meson-sm1-odroid-c4.dts create mode 100644 board/amlogic/odroid-c4/MAINTAINERS create mode 100644 board/amlogic/odroid-c4/Makefile create mode 100644 board/amlogic/odroid-c4/README create mode 100644 board/amlogic/odroid-c4/odroid-c4.c create mode 100644 configs/odroid-c4_defconfig -- 2.25.1
