On 26/03/2020 15.31, Wolfgang Denk wrote:
> Dear Rasmus,
>
>>>
>>> I can see where the increase in text size is coming from - your
>>> removal of #ifdef's now unconditionally includes some code that was
>>> omitted before, for example functions env_fat_save(),
>>> env_ext4_save(), env_sf_save(),
Dear Rasmus,
In message <51077b65-56c1-464a-8721-77b6a7bf3...@prevas.dk> you wrote:
> >
> > I think you did no really answer to some of my concerns.
> >
> > In Message <20200219132715.1f81a240...@gemini.denx.de> I asked:
> >
> > | Have you tested that this works? How do the sizes of the
> > |
On 25/03/2020 08.50, Wolfgang Denk wrote:
> Dear Rasmus Villemoes,
>
> In message <9c03710e-5eec-da6e-6c15-2f8a14cfc...@prevas.dk> you wrote:
>>
>> Can I ask whether you request changes to this patch series or if my
>> answers to your various comments have been satisfactory?
>
> I think you did
Dear Rasmus Villemoes,
In message <9c03710e-5eec-da6e-6c15-2f8a14cfc...@prevas.dk> you wrote:
>
> Can I ask whether you request changes to this patch series or if my
> answers to your various comments have been satisfactory?
I think you did no really answer to some of my concerns.
In Message
On 19/02/2020 10.47, Rasmus Villemoes wrote:
> The various env storage drivers almost all have their own logic [1]
> for deciding whether to compile and provide the .save method, many of
> which fail to honour CONFIG_SPL_SAVEENV. For example, fat.c and sf.c
> define a CMD_SAVEENV macro only for
On 19/02/2020 14.25, Wolfgang Denk wrote:
> Dear Rasmus,
>
> In message <20200219094726.26798-1-rasmus.villem...@prevas.dk> you wrote:
>>
>> [1] Here's the current conditions for which these three drivers
>> provide .save:
>>
>> SPL U-Boot
>> ext4.c
Dear Rasmus,
In message <20200219094726.26798-1-rasmus.villem...@prevas.dk> you wrote:
>
> [1] Here's the current conditions for which these three drivers
> provide .save:
>
> SPL U-Boot
> ext4.cCONFIG_CMD_SAVEENV=yCONFIG_CMD_SAVEENV=y
> fat.c never
The various env storage drivers almost all have their own logic [1]
for deciding whether to compile and provide the .save method, many of
which fail to honour CONFIG_SPL_SAVEENV. For example, fat.c and sf.c
define a CMD_SAVEENV macro only for !CONFIG_SPL_BUILD, while ext4.c
"only" depends on
8 matches
Mail list logo
