Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-04 Thread Stefan Roese
Hi Josua, On 03.05.22 21:09, Josua Mayer wrote: \o/ Am 03.05.22 um 13:54 schrieb Stefan Roese: Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc:

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Josua Mayer
\o/ Am 03.05.22 um 13:54 schrieb Stefan Roese: Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry -

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Stefan Roese
Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Josua Mayer
Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while creating a new API it makes sense to prepend the

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while creating a new API it makes sense to prepend the function names identical IMHO to not "pollute"

[PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-02 Thread Josua Mayer
- prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc Signed-off-by: Josua Mayer --- cmd/tlv_eeprom.c | 56 +++ include/tlv_eeprom.h | 57