Re: [PATCH 09/11] pci: layerscape: ls_pcie_conf_address can be static
On Fri, Sep 17, 2021 at 03:11:28PM +0300, Vladimir Oltean wrote: > To avoid W=1 build warnings, declare this function as static, since it > is not used outside of this translation module. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Bin Meng Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH 09/11] pci: layerscape: ls_pcie_conf_address can be static
On Fri, Sep 17, 2021 at 8:11 PM Vladimir Oltean wrote: > > To avoid W=1 build warnings, declare this function as static, since it > is not used outside of this translation module. > > Signed-off-by: Vladimir Oltean > --- > drivers/pci/pcie_layerscape_rc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng
[PATCH 09/11] pci: layerscape: ls_pcie_conf_address can be static
To avoid W=1 build warnings, declare this function as static, since it is not used outside of this translation module. Signed-off-by: Vladimir Oltean --- drivers/pci/pcie_layerscape_rc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie_layerscape_rc.c b/drivers/pci/pcie_layerscape_rc.c index bd2c19f7f0c9..f50d6ef65396 100644 --- a/drivers/pci/pcie_layerscape_rc.c +++ b/drivers/pci/pcie_layerscape_rc.c @@ -143,8 +143,8 @@ static int ls_pcie_addr_valid(struct ls_pcie_rc *pcie_rc, pci_dev_t bdf) return 0; } -int ls_pcie_conf_address(const struct udevice *bus, pci_dev_t bdf, -uint offset, void **paddress) +static int ls_pcie_conf_address(const struct udevice *bus, pci_dev_t bdf, + uint offset, void **paddress) { struct ls_pcie_rc *pcie_rc = dev_get_priv(bus); struct ls_pcie *pcie = pcie_rc->pcie; -- 2.25.1