Re: [PATCH 1/1] cmd: CONFIG_CMD_BLOBLIST must depend on CONFIG_BLOBLIST

[Tom Rini]

On Mon, 22 Apr 2024 15:50:10 +0200, Heinrich Schuchardt wrote:

> With CONFIG_CMD_BLOBLIST=y, CONFIG_BLOBLIST=n linker errors occur:
> 
> usr/bin/ld: cmd/bloblist.o: in function `do_bloblist_list':
> cmd/bloblist.c:27:(.text.do_bloblist_list+0x6):
> undefined reference to `bloblist_show_list'
> 
> /usr/bin/ld: cmd/bloblist.o: in function `do_bloblist_info':
> cmd/bloblist.c:19:(.text.do_bloblist_info+0x6):
> undefined reference to `bloblist_show_stats'
> 
> [...]

Applied to u-boot/master, thanks!

-- 
Tom

[PATCH 1/1] cmd: CONFIG_CMD_BLOBLIST must depend on CONFIG_BLOBLIST

[Heinrich Schuchardt]

With CONFIG_CMD_BLOBLIST=y, CONFIG_BLOBLIST=n linker errors occur:

usr/bin/ld: cmd/bloblist.o: in function `do_bloblist_list':
cmd/bloblist.c:27:(.text.do_bloblist_list+0x6):
undefined reference to `bloblist_show_list'

/usr/bin/ld: cmd/bloblist.o: in function `do_bloblist_info':
cmd/bloblist.c:19:(.text.do_bloblist_info+0x6):
undefined reference to `bloblist_show_stats'

Fixes: 4aed22762303 ("bloblist: Add a command")
Signed-off-by: Heinrich Schuchardt 
---
 cmd/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 42757e0cdf1..2386391daf1 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -741,7 +741,8 @@ config CMD_BINOP
 
 config CMD_BLOBLIST
bool "bloblist"
-   default y if BLOBLIST
+   depends on BLOBLIST
+   default y
help
  Show information about the bloblist, a collection of binary blobs
  held in memory that persist between SPL and U-Boot. In the case of
-- 
2.43.0