Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-11-03 Thread Ramon Fried
On Mon, Nov 1, 2021 at 12:04 AM Vladimir Oltean wrote: > > On Sat, Oct 30, 2021 at 04:31:48PM +0300, Ramon Fried wrote: > > > > > > Ping for apply? > > > > > I'll get to the patches today. > > > > > thanks for waking me up :) > > > > > > Why don't you apply patches immediately after reviewing them

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-31 Thread Vladimir Oltean
On Sat, Oct 30, 2021 at 04:31:48PM +0300, Ramon Fried wrote: > > > > > Ping for apply? > > > > I'll get to the patches today. > > > > thanks for waking me up :) > > > > Why don't you apply patches immediately after reviewing them? > It wouldn't make a difference. you were all working on the same fi

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-30 Thread Ramon Fried
On Sat, Oct 30, 2021 at 4:37 PM Bin Meng wrote: > > Hi Ramon, > > On Sat, Oct 30, 2021 at 9:31 PM Ramon Fried wrote: > > > > On Thu, Oct 28, 2021 at 10:29 PM Vladimir Oltean > > wrote: > > > > > > On Thu, Oct 28, 2021 at 09:41:02PM +0300, Ramon Fried wrote: > > > > Bin, patches don't apply clean

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-30 Thread Bin Meng
Hi Ramon, On Sat, Oct 30, 2021 at 9:31 PM Ramon Fried wrote: > > On Thu, Oct 28, 2021 at 10:29 PM Vladimir Oltean > wrote: > > > > On Thu, Oct 28, 2021 at 09:41:02PM +0300, Ramon Fried wrote: > > > Bin, patches don't apply cleanly. can you rebase ? > > > > > > On Thu, Oct 28, 2021 at 7:53 AM Ra

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-30 Thread Ramon Fried
On Thu, Oct 28, 2021 at 10:29 PM Vladimir Oltean wrote: > > On Thu, Oct 28, 2021 at 09:41:02PM +0300, Ramon Fried wrote: > > Bin, patches don't apply cleanly. can you rebase ? > > > > On Thu, Oct 28, 2021 at 7:53 AM Ramon Fried wrote: > > > > > > On Wed, Oct 27, 2021 at 5:19 AM Bin Meng wrote:

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-28 Thread Vladimir Oltean
On Thu, Oct 28, 2021 at 09:41:02PM +0300, Ramon Fried wrote: > Bin, patches don't apply cleanly. can you rebase ? > > On Thu, Oct 28, 2021 at 7:53 AM Ramon Fried wrote: > > > > On Wed, Oct 27, 2021 at 5:19 AM Bin Meng wrote: > > > > > > On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried wrote: > > >

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-28 Thread Ramon Fried
Bin, patches don't apply cleanly. can you rebase ? On Thu, Oct 28, 2021 at 7:53 AM Ramon Fried wrote: > > On Wed, Oct 27, 2021 at 5:19 AM Bin Meng wrote: > > > > On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried wrote: > > > > > > On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean > > > wrote: > > >

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-27 Thread Ramon Fried
On Wed, Oct 27, 2021 at 5:19 AM Bin Meng wrote: > > On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried wrote: > > > > On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean > > wrote: > > > > > > On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote: > > > > set_promisc() call accepts the parameter of a b

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-26 Thread Bin Meng
On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried wrote: > > On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean > wrote: > > > > On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote: > > > set_promisc() call accepts the parameter of a bool type. Make it > > > clear by using true instead of 1. > > > >

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-16 Thread Ramon Fried
On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean wrote: > > On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote: > > set_promisc() call accepts the parameter of a bool type. Make it > > clear by using true instead of 1. > > > > Signed-off-by: Bin Meng > > --- > > > > net/dsa-uclass.c | 2 +-

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-09-29 Thread Vladimir Oltean
On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote: > set_promisc() call accepts the parameter of a bool type. Make it > clear by using true instead of 1. > > Signed-off-by: Bin Meng > --- > > net/dsa-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/d

[PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-09-28 Thread Bin Meng
set_promisc() call accepts the parameter of a bool type. Make it clear by using true instead of 1. Signed-off-by: Bin Meng --- net/dsa-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index 694664d81b..dcefec03f4 100644 --- a/net/d