Re: [PATCH 1/5] patman: test_util: Fix printing results for failed tests
On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak wrote: > > When printing a python tool's test results, the entire list of failed > tests and their tracebacks are reprinted for every failed test. This > makes the test output quite unreadable. Fix the loop to print failures > and tracebacks one at a time. > > Signed-off-by: Alper Nebi Yasak > --- > > tools/patman/test_util.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!
Re: [PATCH 1/5] patman: test_util: Fix printing results for failed tests
On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak wrote: > > When printing a python tool's test results, the entire list of failed > tests and their tracebacks are reprinted for every failed test. This > makes the test output quite unreadable. Fix the loop to print failures > and tracebacks one at a time. > > Signed-off-by: Alper Nebi Yasak > --- > > tools/patman/test_util.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass
[PATCH 1/5] patman: test_util: Fix printing results for failed tests
When printing a python tool's test results, the entire list of failed
tests and their tracebacks are reprinted for every failed test. This
makes the test output quite unreadable. Fix the loop to print failures
and tracebacks one at a time.
Signed-off-by: Alper Nebi Yasak
---
tools/patman/test_util.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/patman/test_util.py b/tools/patman/test_util.py
index c60eb3628e23..8b2220dbbafc 100644
--- a/tools/patman/test_util.py
+++ b/tools/patman/test_util.py
@@ -127,7 +127,7 @@ def report_result(toolname:str, test_name: str, result:
unittest.TestResult):
for test, err in result.errors:
print(test.id(), err)
for test, err in result.failures:
-print(err, result.failures)
+print(test.id(), err)
if result.skipped:
print('%d %s test%s SKIPPED:' % (len(result.skipped), toolname,
's' if len(result.skipped) > 1 else ''))
--
2.35.1
