Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-09-22 Thread Tom Rini
On Mon, Aug 02, 2021 at 03:18:38PM +0200, Pali Rohár wrote: > Header file version.h does not use anything from timestamp.h. Including of > timestamp.h has side effect which cause recompiling object file at every > make run because timestamp.h changes at every run. > > So remove timestamp.h from

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Pali Rohár
On Wednesday 04 August 2021 18:15:55 Tom Rini wrote: > On Thu, Aug 05, 2021 at 12:14:29AM +0200, Pali Rohár wrote: > > On Wednesday 04 August 2021 18:09:14 Tom Rini wrote: > > > On Wed, Aug 04, 2021 at 05:43:41PM -0400, Sean Anderson wrote: > > > > > > > > > > > > On 8/2/21 3:21 PM, Simon Glass

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Tom Rini
On Thu, Aug 05, 2021 at 12:14:29AM +0200, Pali Rohár wrote: > On Wednesday 04 August 2021 18:09:14 Tom Rini wrote: > > On Wed, Aug 04, 2021 at 05:43:41PM -0400, Sean Anderson wrote: > > > > > > > > > On 8/2/21 3:21 PM, Simon Glass wrote: > > > > Hi Pali, > > > > > > > > On Mon, 2 Aug 2021 at

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Pali Rohár
On Wednesday 04 August 2021 18:09:14 Tom Rini wrote: > On Wed, Aug 04, 2021 at 05:43:41PM -0400, Sean Anderson wrote: > > > > > > On 8/2/21 3:21 PM, Simon Glass wrote: > > > Hi Pali, > > > > > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > > > > > Header file version.h does not use

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Tom Rini
On Wed, Aug 04, 2021 at 05:43:41PM -0400, Sean Anderson wrote: > > > On 8/2/21 3:21 PM, Simon Glass wrote: > > Hi Pali, > > > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > > > Header file version.h does not use anything from timestamp.h. Including of > > > timestamp.h has side

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Pali Rohár
On Wednesday 04 August 2021 17:43:41 Sean Anderson wrote: > On 8/2/21 3:21 PM, Simon Glass wrote: > > Hi Pali, > > > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > > > Header file version.h does not use anything from timestamp.h. Including of > > > timestamp.h has side effect which

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Pali Rohár
On Wednesday 04 August 2021 10:40:42 Tom Rini wrote: > On Wed, Aug 04, 2021 at 08:36:27AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 4 Aug 2021 at 06:44, Tom Rini wrote: > > > > > > On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > > > > > > > Dear Tom, > > > > > > > >

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Sean Anderson
On 8/2/21 3:21 PM, Simon Glass wrote: Hi Pali, On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: Header file version.h does not use anything from timestamp.h. Including of timestamp.h has side effect which cause recompiling object file at every make run because timestamp.h changes at every

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Tom Rini
On Wed, Aug 04, 2021 at 08:36:27AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 4 Aug 2021 at 06:44, Tom Rini wrote: > > > > On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > > > > > Dear Tom, > > > > > > In message <20210802213100.GG9379@bill-the-cat> you wrote: > > > > > > >

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Simon Glass
Hi Tom, On Wed, 4 Aug 2021 at 06:44, Tom Rini wrote: > > On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > > > Dear Tom, > > > > In message <20210802213100.GG9379@bill-the-cat> you wrote: > > > > > > I think that if nothing changes the banner not changing is the right > > >

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-04 Thread Tom Rini
On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20210802213100.GG9379@bill-the-cat> you wrote: > > > > I think that if nothing changes the banner not changing is the right > > behavior. > > Hm... is it? How about "external" changes like building with

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-03 Thread Wolfgang Denk
Dear Tom, In message <20210802213100.GG9379@bill-the-cat> you wrote: > > I think that if nothing changes the banner not changing is the right > behavior. Hm... is it? How about "external" changes like building with a different tool chain? Then at least the "version" command should produce a

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 09:42:23PM +0200, Pali Rohár wrote: > On Monday 02 August 2021 13:21:58 Simon Glass wrote: > > Hi Pali, > > > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > > > Header file version.h does not use anything from timestamp.h. Including of > > > timestamp.h has side

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 13:21:58 Simon Glass wrote: > Hi Pali, > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > Header file version.h does not use anything from timestamp.h. Including of > > timestamp.h has side effect which cause recompiling object file at every > > make run because

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-02 Thread Simon Glass
Hi Pali, On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > Header file version.h does not use anything from timestamp.h. Including of > timestamp.h has side effect which cause recompiling object file at every > make run because timestamp.h changes at every run. > > So remove timestamp.h from

[PATCH 11/11] Remove including timestamp.h in version.h

2021-08-02 Thread Pali Rohár
Header file version.h does not use anything from timestamp.h. Including of timestamp.h has side effect which cause recompiling object file at every make run because timestamp.h changes at every run. So remove timestamp.h from version.h and include timestamp.h in files which needs it. This change