Re: [PATCH 2/2] x86: apl: Re-enable loading of SPL
On Tue, Jul 7, 2020 at 3:56 PM Bin Meng wrote:
>
> On Mon, Jul 6, 2020 at 10:16 AM Simon Glass wrote:
> >
> > At present the SPL loader is not included in the TPL image so SPL cannot
> > be loaded. Fix it by including this file for both SPL and TPL.
> >
> > Signed-off-by: Simon Glass
> > Fixes: c87f9ce2273 ("x86: Don't build some unused objects in TPL")
> > ---
> >
> > arch/x86/cpu/apollolake/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng
applied to u-boot-x86, thanks!
Re: [PATCH 2/2] x86: apl: Re-enable loading of SPL
On Mon, Jul 6, 2020 at 10:16 AM Simon Glass wrote:
>
> At present the SPL loader is not included in the TPL image so SPL cannot
> be loaded. Fix it by including this file for both SPL and TPL.
>
> Signed-off-by: Simon Glass
> Fixes: c87f9ce2273 ("x86: Don't build some unused objects in TPL")
> ---
>
> arch/x86/cpu/apollolake/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng
[PATCH 2/2] x86: apl: Re-enable loading of SPL
At present the SPL loader is not included in the TPL image so SPL cannot
be loaded. Fix it by including this file for both SPL and TPL.
Signed-off-by: Simon Glass
Fixes: c87f9ce2273 ("x86: Don't build some unused objects in TPL")
---
arch/x86/cpu/apollolake/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/cpu/apollolake/Makefile b/arch/x86/cpu/apollolake/Makefile
index 11621256ae..3aa2a55676 100644
--- a/arch/x86/cpu/apollolake/Makefile
+++ b/arch/x86/cpu/apollolake/Makefile
@@ -3,6 +3,7 @@
# Copyright 2019 Google LLC
obj-$(CONFIG_SPL_BUILD) += cpu_spl.o
+obj-$(CONFIG_SPL_BUILD) += spl.o
obj-$(CONFIG_SPL_BUILD) += systemagent.o
obj-y += cpu_common.o
@@ -11,7 +12,6 @@ obj-y += cpu.o
obj-y += punit.o
obj-y += fsp_bindings.o
ifdef CONFIG_SPL_BUILD
-obj-y += spl.o
obj-y += fsp_m.o
endif
endif
--
2.27.0.212.ge8ba1cc988-goog
