Re: [PATCH 2/3] efi_loader: GOP: Add 30bpp support

2021-09-25 Thread Simon Glass
Hi Mark, On Thu, 16 Sept 2021 at 07:02, Mark Kettenis wrote: > > Provide correct framebuffer information for 30bpp modes. > > Signed-off-by: Mark Kettenis > --- > lib/efi_loader/efi_gop.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/lib/efi_loader/efi_gop.c

Re: [PATCH 2/3] efi_loader: GOP: Add 30bpp support

2021-09-17 Thread Mark Kettenis
> From: Heinrich Schuchardt > Date: Fri, 17 Sep 2021 13:29:06 +0200 > > On 9/17/21 11:23 AM, Mark Kettenis wrote: > >> From: Heinrich Schuchardt > >> Date: Fri, 17 Sep 2021 04:56:31 +0200 > > > > Hi Heinrich, > > > >> On 9/16/21 3:01 PM, Mark Kettenis wrote: > >>> Provide correct framebuffer

Re: [PATCH 2/3] efi_loader: GOP: Add 30bpp support

2021-09-17 Thread Heinrich Schuchardt
On 9/17/21 11:23 AM, Mark Kettenis wrote: From: Heinrich Schuchardt Date: Fri, 17 Sep 2021 04:56:31 +0200 Hi Heinrich, On 9/16/21 3:01 PM, Mark Kettenis wrote: Provide correct framebuffer information for 30bpp modes. This is not enough to get a correct GOP implementation for the 30bpp

Re: [PATCH 2/3] efi_loader: GOP: Add 30bpp support

2021-09-17 Thread Mark Kettenis
> From: Heinrich Schuchardt > Date: Fri, 17 Sep 2021 04:56:31 +0200 Hi Heinrich, > On 9/16/21 3:01 PM, Mark Kettenis wrote: > > Provide correct framebuffer information for 30bpp modes. > > This is not enough to get a correct GOP implementation for the 30bpp mode. > > Have a look at

Re: [PATCH 2/3] efi_loader: GOP: Add 30bpp support

2021-09-16 Thread Heinrich Schuchardt
On 9/16/21 3:01 PM, Mark Kettenis wrote: Provide correct framebuffer information for 30bpp modes. This is not enough to get a correct GOP implementation for the 30bpp mode. Have a look at efi_gop_pixel efi_vid16_to_blt_col() and efi_blt_col_to_vid16() and where they are used.

[PATCH 2/3] efi_loader: GOP: Add 30bpp support

2021-09-16 Thread Mark Kettenis
Provide correct framebuffer information for 30bpp modes. Signed-off-by: Mark Kettenis --- lib/efi_loader/efi_gop.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c index 1206b2d7a2..42bf49b184 100644 ---