Re: [PATCH 21/22] x86: mtrr: Update 'mtrr' to allow setting MTRRs on any CPU

[Wolfgang Wallner]

Hi Simon,

-"Simon Glass"  schrieb: -
> Betreff: [PATCH 21/22] x86: mtrr: Update 'mtrr' to allow setting MTRRs on any 
> CPU
> 
> Add a -c option to mtrr to allow any CPU to be updated with this command.
> 
> Signed-off-by: Simon Glass 
> ---
> 
>  cmd/x86/mtrr.c | 18 --
>  1 file changed, 16 insertions(+), 2 deletions(-)

Reviewed-by: Wolfgang Wallner 

[PATCH 21/22] x86: mtrr: Update 'mtrr' to allow setting MTRRs on any CPU

[Simon Glass]

Add a -c option to mtrr to allow any CPU to be updated with this command.

Signed-off-by: Simon Glass 
---

 cmd/x86/mtrr.c | 18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/cmd/x86/mtrr.c b/cmd/x86/mtrr.c
index fea7a437db8..8365a7978ff 100644
--- a/cmd/x86/mtrr.c
+++ b/cmd/x86/mtrr.c
@@ -104,6 +104,17 @@ static int do_mtrr(struct cmd_tbl *cmdtp, int flag, int 
argc,
int ret;
 
cpu_select = MP_SELECT_BSP;
+   if (argc >= 3 && !strcmp("-c", argv[1])) {
+   const char *cpustr;
+
+   cpustr = argv[2];
+   if (*cpustr == 'a')
+   cpu_select = MP_SELECT_ALL;
+   else
+   cpu_select = simple_strtol(cpustr, NULL, 16);
+   argc -= 2;
+   argv += 2;
+   }
argc--;
argv++;
cmd = argv[0] ? *argv[0] : 0;
@@ -145,11 +156,14 @@ static int do_mtrr(struct cmd_tbl *cmdtp, int flag, int 
argc,
 }
 
 U_BOOT_CMD(
-   mtrr,   6,  1,  do_mtrr,
+   mtrr,   8,  1,  do_mtrr,
"Use x86 memory type range registers (32-bit only)",
"[list]- list current registers\n"
"set   - set a register\n"
"\t is Uncacheable, Combine, Through, Protect, Back\n"
"disable   - disable a register\n"
-   "enable- enable a register"
+   "enable- enable a register\n"
+   "\n"
+   "Precede command with '-c |all' to access a particular CPU, e.g.\n"
+   "   mtrr -c all list; mtrr -c 2e list"
 );
-- 
2.27.0.rc0.183.gde8f92d652-goog