Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-04-24 Thread Tom Rini
On Wed, Feb 19, 2020 at 09:47:41AM +, Rasmus Villemoes wrote: > Always compile the env_fat_save() function, and let > CONFIG_IS_ENABLED(SAVEENV) (via the ENV_SAVE_PTR macro) decide whether > it actually ends up being compiled in. > > Signed-off-by: Rasmus Villemoes Applied to

Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-24 Thread Rasmus Villemoes
On 21/02/2020 17.19, Tom Rini wrote: > On Fri, Feb 21, 2020 at 05:14:14PM +0100, Wolfgang Denk wrote: >> Dear Rasmus, >> >> In message <5265fdd5-3992-4e5f-3235-5586b3b77...@prevas.dk> you wrote: >>> >>> So without the fat.c patch, CONFIG_SPL_SAVEENV is effectively ignored. >> >> OK, but what about

Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-21 Thread Tom Rini
On Fri, Feb 21, 2020 at 05:14:14PM +0100, Wolfgang Denk wrote: > Dear Rasmus, > > In message <5265fdd5-3992-4e5f-3235-5586b3b77...@prevas.dk> you wrote: > > > > So without the fat.c patch, CONFIG_SPL_SAVEENV is effectively ignored. > > OK, but what about bords that don't store the envionment in

Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-21 Thread Wolfgang Denk
Dear Rasmus, In message <5265fdd5-3992-4e5f-3235-5586b3b77...@prevas.dk> you wrote: > > So without the fat.c patch, CONFIG_SPL_SAVEENV is effectively ignored. OK, but what about bords that don't store the envionment in a file system, but instead for example in (parallel or SPI) NOR flash or in a

Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-20 Thread Rasmus Villemoes
On 19/02/2020 14.27, Wolfgang Denk wrote: > Dear Rasmus, > > In message <20200219094726.26798-4-rasmus.villem...@prevas.dk> you wrote: >> Always compile the env_fat_save() function, and let >> CONFIG_IS_ENABLED(SAVEENV) (via the ENV_SAVE_PTR macro) decide whether >> it actually ends up being

Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-19 Thread Wolfgang Denk
Dear Rasmus, In message <20200219094726.26798-4-rasmus.villem...@prevas.dk> you wrote: > Always compile the env_fat_save() function, and let > CONFIG_IS_ENABLED(SAVEENV) (via the ENV_SAVE_PTR macro) decide whether > it actually ends up being compiled in. Have you tested that this works? How do

[PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-19 Thread Rasmus Villemoes
Always compile the env_fat_save() function, and let CONFIG_IS_ENABLED(SAVEENV) (via the ENV_SAVE_PTR macro) decide whether it actually ends up being compiled in. Signed-off-by: Rasmus Villemoes --- env/fat.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/env/fat.c