Re: [PATCH 4/4] binman: update documentation for fit,align property
Hi Rasmus, On Tue, 26 Sept 2023 at 00:25, Rasmus Villemoes wrote: > > On 25/09/2023 17.14, Jonas Karlman wrote: > > >> fit,align > >> -Indicates what alignment to use for the FIT and its external data, > >> -and provides the alignment to use. This is passed to mkimage via > >> -the -B flag. > >> +Indicates what alignment to use for the FIT and, if applicable, > >> +its external data. This is passed to mkimage via the -B flag. > > > > This only updates entries.rst, please update tools/binman/etype/fit.py > > and re-generate entries.rst from output of running binman entry-docs. > > Ah, I didn't know the .rst was generated. > > Simon, want me to resend (this one or the whole series?), or can you > fold in this when applying: I can fold it in, so long as I remember. > > diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py > index 2c14b15b03..97d3cedaf5 100644 > --- a/tools/binman/etype/fit.py > +++ b/tools/binman/etype/fit.py > @@ -71,9 +71,8 @@ class Entry_fit(Entry_section): > external offset. This is passed to mkimage via the -E and > -p flags. > > fit,align > -Indicates what alignment to use for the FIT and its > external data, > -and provides the alignment to use. This is passed to > mkimage via > -the -B flag. > +Indicates what alignment to use for the FIT and, if applicable, > +its external data. This is passed to mkimage via the -B flag. > > fit,fdt-list > Indicates the entry argument which provides the list of > device tree > > Rasmus > Regards, Simon
Re: [PATCH 4/4] binman: update documentation for fit,align property
On 25/09/2023 17.14, Jonas Karlman wrote: >> fit,align >> -Indicates what alignment to use for the FIT and its external data, >> -and provides the alignment to use. This is passed to mkimage via >> -the -B flag. >> +Indicates what alignment to use for the FIT and, if applicable, >> +its external data. This is passed to mkimage via the -B flag. > > This only updates entries.rst, please update tools/binman/etype/fit.py > and re-generate entries.rst from output of running binman entry-docs. Ah, I didn't know the .rst was generated. Simon, want me to resend (this one or the whole series?), or can you fold in this when applying: diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py index 2c14b15b03..97d3cedaf5 100644 --- a/tools/binman/etype/fit.py +++ b/tools/binman/etype/fit.py @@ -71,9 +71,8 @@ class Entry_fit(Entry_section): external offset. This is passed to mkimage via the -E and -p flags. fit,align -Indicates what alignment to use for the FIT and its external data, -and provides the alignment to use. This is passed to mkimage via -the -B flag. +Indicates what alignment to use for the FIT and, if applicable, +its external data. This is passed to mkimage via the -B flag. fit,fdt-list Indicates the entry argument which provides the list of device tree Rasmus
Re: [PATCH 4/4] binman: update documentation for fit,align property
Hi Rasmus, On 2023-09-19 13:37, Rasmus Villemoes wrote: > Eliminate the repetition "what alignment to use ... and provides the > alignment to use", and indicate that fit,align can both be used by > itself and together with fit,external-offset. > > Signed-off-by: Rasmus Villemoes > --- > tools/binman/entries.rst | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/binman/entries.rst b/tools/binman/entries.rst > index e7dfe6b2a3..f9ad27ce8c 100644 > --- a/tools/binman/entries.rst > +++ b/tools/binman/entries.rst > @@ -691,9 +691,8 @@ The top-level 'fit' node supports the following special > properties: > external offset. This is passed to mkimage via the -E and -p flags. > > fit,align > -Indicates what alignment to use for the FIT and its external data, > -and provides the alignment to use. This is passed to mkimage via > -the -B flag. > +Indicates what alignment to use for the FIT and, if applicable, > +its external data. This is passed to mkimage via the -B flag. This only updates entries.rst, please update tools/binman/etype/fit.py and re-generate entries.rst from output of running binman entry-docs. Regards, Jonas > > fit,fdt-list > Indicates the entry argument which provides the list of device tree
Re: [PATCH 4/4] binman: update documentation for fit,align property
On Tue, 19 Sept 2023 at 05:37, Rasmus Villemoes wrote: > > Eliminate the repetition "what alignment to use ... and provides the > alignment to use", and indicate that fit,align can both be used by > itself and together with fit,external-offset. > > Signed-off-by: Rasmus Villemoes > --- > tools/binman/entries.rst | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass
[PATCH 4/4] binman: update documentation for fit,align property
Eliminate the repetition "what alignment to use ... and provides the alignment to use", and indicate that fit,align can both be used by itself and together with fit,external-offset. Signed-off-by: Rasmus Villemoes --- tools/binman/entries.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/binman/entries.rst b/tools/binman/entries.rst index e7dfe6b2a3..f9ad27ce8c 100644 --- a/tools/binman/entries.rst +++ b/tools/binman/entries.rst @@ -691,9 +691,8 @@ The top-level 'fit' node supports the following special properties: external offset. This is passed to mkimage via the -E and -p flags. fit,align -Indicates what alignment to use for the FIT and its external data, -and provides the alignment to use. This is passed to mkimage via -the -B flag. +Indicates what alignment to use for the FIT and, if applicable, +its external data. This is passed to mkimage via the -B flag. fit,fdt-list Indicates the entry argument which provides the list of device tree -- 2.37.2
