Re: [PATCH 4/4] make env_entry::callback conditional on !CONFIG_SPL_BUILD

2020-04-24 Thread Tom Rini
On Thu, Feb 27, 2020 at 01:56:12PM +, Rasmus Villemoes wrote: > The callback member of struct env_entry is always NULL for an SPL > build. Removing it thus saves a bit of run-time memory in the > SPL (when CONFIG_SPL_ENV_SUPPORT=y) since struct env_entry is embedded > in struct env_entry_node

Re: [PATCH 4/4] make env_entry::callback conditional on !CONFIG_SPL_BUILD

2020-02-27 Thread Simon Glass
On Thu, 27 Feb 2020 at 05:56, Rasmus Villemoes wrote: > > The callback member of struct env_entry is always NULL for an SPL > build. Removing it thus saves a bit of run-time memory in the > SPL (when CONFIG_SPL_ENV_SUPPORT=y) since struct env_entry is embedded > in struct env_entry_node - i.e.

[PATCH 4/4] make env_entry::callback conditional on !CONFIG_SPL_BUILD

2020-02-27 Thread Rasmus Villemoes
The callback member of struct env_entry is always NULL for an SPL build. Removing it thus saves a bit of run-time memory in the SPL (when CONFIG_SPL_ENV_SUPPORT=y) since struct env_entry is embedded in struct env_entry_node - i.e. about 2KB for the normal case of 512+change hash table entries.