Re: [PATCH 4/5] env/ext4.c: remove CONFIG_CMD_SAVEENV ifdef

2020-04-24 Thread Tom Rini
On Wed, Feb 19, 2020 at 09:47:42AM +, Rasmus Villemoes wrote: > Removing this ifdef/endif pair yields a "defined but unused warning" > for CONFIG_CMD_SAVEENV=n, but that vanishes if we use the ENV_SAVE_PTR > macro instead. This gives slightly better compile testing, and > moreover, it's

[PATCH 4/5] env/ext4.c: remove CONFIG_CMD_SAVEENV ifdef

2020-02-19 Thread Rasmus Villemoes
Removing this ifdef/endif pair yields a "defined but unused warning" for CONFIG_CMD_SAVEENV=n, but that vanishes if we use the ENV_SAVE_PTR macro instead. This gives slightly better compile testing, and moreover, it's possible to have CONFIG_CMD_SAVEENV=n CONFIG_SPL_SAVEENV=y