Re: [PATCH 5/5] cyclic: get rid of cyclic_init()

2022-11-02 Thread Stefan Roese
On 29.10.22 00:38, Rasmus Villemoes wrote: On 28/10/2022 16.10, Stefan Roese wrote: On 28.10.22 13:50, Rasmus Villemoes wrote: As for cyclic_uninit(), it was never really the opposite of cyclic_init() since it didn't free the struct cyclic_drv nor set gd->cyclic to NULL. Rename it to

Re: [PATCH 5/5] cyclic: get rid of cyclic_init()

2022-10-28 Thread Rasmus Villemoes
On 28/10/2022 16.10, Stefan Roese wrote: > On 28.10.22 13:50, Rasmus Villemoes wrote: >> As for cyclic_uninit(), it was never really the opposite of >> cyclic_init() since it didn't free the struct cyclic_drv nor set >> gd->cyclic to NULL. Rename it to cyclic_unregister_all() and use that >> in

Re: [PATCH 5/5] cyclic: get rid of cyclic_init()

2022-10-28 Thread Stefan Roese
On 28.10.22 13:50, Rasmus Villemoes wrote: Currently, we must call cyclic_init() at some point before cyclic_register() becomes possible. That turns out to be somewhat awkward, especially with SPL, and has resulted in a watchdog callback not being registered, thus causing the board to

[PATCH 5/5] cyclic: get rid of cyclic_init()

2022-10-28 Thread Rasmus Villemoes
Currently, we must call cyclic_init() at some point before cyclic_register() becomes possible. That turns out to be somewhat awkward, especially with SPL, and has resulted in a watchdog callback not being registered, thus causing the board to prematurely reset. We already rely on gd->cyclic