Re: [PATCH 6/8] net: dwc_eth_qos: Split eqos_start() to get link speed

2020-05-11 Thread David Wu
Hi Patrice, 在 2020/5/11 下午8:48, Patrice CHOTARD 写道: Hi David On 5/9/20 8:42 AM, David Wu wrote: Hi Patrice, 在 2020/4/30 下午11:33, Patrice CHOTARD 写道: Can you explain why you are splitting this function in 2 parts and calling these parts sequentially ? For rockchip, need to obtain the

Re: [PATCH 6/8] net: dwc_eth_qos: Split eqos_start() to get link speed

2020-05-11 Thread Patrice CHOTARD
Hi David On 5/9/20 8:42 AM, David Wu wrote: > Hi Patrice, > > 在 2020/4/30 下午11:33, Patrice CHOTARD 写道: >> Can you explain why you are splitting this function in 2 parts and calling >> these parts sequentially ? > > For rockchip, need to obtain the current link speed to configure the tx >

Re: [PATCH 6/8] net: dwc_eth_qos: Split eqos_start() to get link speed

2020-05-09 Thread David Wu
Hi Patrice, 在 2020/4/30 下午11:33, Patrice CHOTARD 写道: Can you explain why you are splitting this function in 2 parts and calling these parts sequentially ? For rockchip, need to obtain the current link speed to configure the tx clocks, (for example, in rgmii mode, 1000M link: 125M, 100M

Re: [PATCH 6/8] net: dwc_eth_qos: Split eqos_start() to get link speed

2020-04-30 Thread Patrice CHOTARD
Hi David On 4/30/20 12:44 PM, David Wu wrote: > Before enabling mac and mac working, we need to obtain > the current link speed to configure the clock, so split > eqos_start into two functions. > > Signed-off-by: David Wu > --- > > drivers/net/dwc_eth_qos.c | 56

[PATCH 6/8] net: dwc_eth_qos: Split eqos_start() to get link speed

2020-04-30 Thread David Wu
Before enabling mac and mac working, we need to obtain the current link speed to configure the clock, so split eqos_start into two functions. Signed-off-by: David Wu --- drivers/net/dwc_eth_qos.c | 56 ++- 1 file changed, 38 insertions(+), 18 deletions(-)