Re: [PATCH V2 10/10] include: env: ti: Drop default_findfdt
Nishanth Menon writes:
> We shouldn't need finfdt anymore. Drop the env script.
>
> Signed-off-by: Nishanth Menon
> ---
> Changes from V1: None.
>
> V1: https://lore.kernel.org/r/20240108173301.2692332-11...@ti.com
> include/env/ti/default_findfdt.env | 12
> 1 file changed, 12 deletions(-)
> delete mode 100644 include/env/ti/default_findfdt.env
>
> diff --git a/include/env/ti/default_findfdt.env
> b/include/env/ti/default_findfdt.env
> deleted file mode 100644
> index a2b51dd923bb..
> --- a/include/env/ti/default_findfdt.env
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -default_device_tree=CONFIG_DEFAULT_DEVICE_TREE
> -default_device_tree_arch=ti
> -#ifdef CONFIG_ARM64
> -findfdt=
> - setenv name_fdt ${default_device_tree_arch}/${default_device_tree}.dtb;
> - setenv fdtfile ${name_fdt}
> -#else
> -default_device_tree_subarch=omap
> -findfdt=
> - setenv name_fdt
> ${default_device_tree_arch}/${default_device_tree_subarch}/${default_device_tree}.dtb;
> - setenv fdtfile ${name_fdt}
> -#endif
> --
> 2.43.0
Reviewed-by: Jonathan Humphreys
Re: [PATCH V2 10/10] include: env: ti: Drop default_findfdt
On 19:31-20240110, Roger Quadros wrote:
>
>
[..]
> FYI. findfdt is still used in:
>
> am335x_baltos_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run usbboot;run
> mmcboot;setenv mmcdev 1; setenv bootpart 1:2; run mmcboot;run nandboot;"
> am335x_boneblack_vboot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run
> init_console; run finduuid; run distro_bootcmd"
> am335x_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run init_console; run
> finduuid; run distro_bootcmd"
> am335x_evm_spiboot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run
> init_console; run finduuid; run distro_bootcmd"
> am335x_hs_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run init_console;
> run finduuid; run distro_bootcmd"
> am335x_hs_evm_uart_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run
> init_console; run finduuid; run distro_bootcmd"
> am335x_igep003x_defconfig:CONFIG_BOOTCOMMAND="run findfdt;run mmcboot;run
> nandboot;run netboot;"
> am43xx_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run
> distro_bootcmd"
> am43xx_evm_qspiboot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid;
> run distro_bootcmd"
> am43xx_evm_rtconly_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid;
> run distro_bootcmd"
> am43xx_evm_usbhost_boot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run
> finduuid; run distro_bootcmd"
> am43xx_hs_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run
> distro_bootcmd"
> am43xx_hs_evm_qspi_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid;
> run distro_bootcmd"
> am57xx_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then
> echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
> saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
> 1; then run update_to_fit;fi;run findfdt; run finduuid; run
> distro_bootcmd;run emmc_android_boot; "
> am57xx_hs_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then
> echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
> saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
> 1; then run update_to_fit;fi;run findfdt; run finduuid; run
> distro_bootcmd;run emmc_android_boot; "
> am57xx_hs_evm_usb_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1;
> then echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot
> 0; saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit}
> -eq 1; then run update_to_fit;fi;run findfdt; run finduuid; run
> distro_bootcmd;run emmc_android_boot; "
> am65x_evm_a53_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd;
> run init_${boot}; run boot_rprocs; if test ${boot_fit} -eq 1; then run
> get_fit_${boot}; run get_overlaystring; run run_fit; else; run
> get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern;
> fi;"
> dra7xx_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then
> echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
> saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
> 1; then run update_to_fit;fi;run findfdt; run finduuid; run
> distro_bootcmd;run emmc_android_boot; "
> dra7xx_hs_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then
> echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
> saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
> 1; then run update_to_fit;fi;run findfdt; run finduuid; run
> distro_bootcmd;run emmc_android_boot; "
> dra7xx_hs_evm_usb_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1;
> then echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot
> 0; saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit}
> -eq 1; then run update_to_fit;fi;run findfdt; run finduuid; run
> distro_bootcmd;run emmc_android_boot; "
> k2g_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run envboot; run
> init_${boot}; run get_mon_${boot} run_mon; run set_name_pmmc get_pmmc_${boot}
> run_pmmc; run get_kern_${boot}; run init_fw_rd_${boot}; run get_fdt_${boot};
> run run_kern"
> k2g_hs_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run envboot; run
> run_mon_hs; run init_${boot}; run get_fit_${boot}; bootm
> ${addr_fit}#${name_fdt}"
> omap3_beagle_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd"
> omap4_panda_defconfig:CONFIG_BOOTCOMMAND="if test ${boot_fit} -eq 1; then run
> update_to_fit; fi; run findfdt; run init_console; run envboot; run
> distro_bootcmd"
> omap4_sdp4430_defconfig:CONFIG_BOOTCOMMAND="if test ${boot_fit} -eq 1; then
> run update_to_fit; fi; run findfdt; run init_console; run envboot; run
> distro_bootcmd"
Yep - I have not cleaned up OR moved to stdboot any of the older
platforms (pre k3). That said the script that this patch is deleting is
not used anywhere else at this point in the series. So, it is safe to
remove. The existing platforms implement findfdt in
Re: [PATCH V2 10/10] include: env: ti: Drop default_findfdt
On 09/01/2024 21:15, Nishanth Menon wrote:
> We shouldn't need finfdt anymore. Drop the env script.
>
> Signed-off-by: Nishanth Menon
> ---
> Changes from V1: None.
>
> V1: https://lore.kernel.org/r/20240108173301.2692332-11...@ti.com
> include/env/ti/default_findfdt.env | 12
> 1 file changed, 12 deletions(-)
> delete mode 100644 include/env/ti/default_findfdt.env
>
> diff --git a/include/env/ti/default_findfdt.env
> b/include/env/ti/default_findfdt.env
> deleted file mode 100644
> index a2b51dd923bb..
> --- a/include/env/ti/default_findfdt.env
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -default_device_tree=CONFIG_DEFAULT_DEVICE_TREE
> -default_device_tree_arch=ti
> -#ifdef CONFIG_ARM64
> -findfdt=
> - setenv name_fdt ${default_device_tree_arch}/${default_device_tree}.dtb;
> - setenv fdtfile ${name_fdt}
> -#else
> -default_device_tree_subarch=omap
> -findfdt=
> - setenv name_fdt
> ${default_device_tree_arch}/${default_device_tree_subarch}/${default_device_tree}.dtb;
> - setenv fdtfile ${name_fdt}
> -#endif
FYI. findfdt is still used in:
am335x_baltos_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run usbboot;run
mmcboot;setenv mmcdev 1; setenv bootpart 1:2; run mmcboot;run nandboot;"
am335x_boneblack_vboot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run
init_console; run finduuid; run distro_bootcmd"
am335x_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run init_console; run
finduuid; run distro_bootcmd"
am335x_evm_spiboot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run init_console;
run finduuid; run distro_bootcmd"
am335x_hs_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run init_console; run
finduuid; run distro_bootcmd"
am335x_hs_evm_uart_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run init_console;
run finduuid; run distro_bootcmd"
am335x_igep003x_defconfig:CONFIG_BOOTCOMMAND="run findfdt;run mmcboot;run
nandboot;run netboot;"
am43xx_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run
distro_bootcmd"
am43xx_evm_qspiboot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid;
run distro_bootcmd"
am43xx_evm_rtconly_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run
distro_bootcmd"
am43xx_evm_usbhost_boot_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run
finduuid; run distro_bootcmd"
am43xx_hs_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run
distro_bootcmd"
am43xx_hs_evm_qspi_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run
distro_bootcmd"
am57xx_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then echo
Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
1; then run update_to_fit;fi;run findfdt; run finduuid; run distro_bootcmd;run
emmc_android_boot; "
am57xx_hs_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then
echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
1; then run update_to_fit;fi;run findfdt; run finduuid; run distro_bootcmd;run
emmc_android_boot; "
am57xx_hs_evm_usb_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1;
then echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot
0; saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit}
-eq 1; then run update_to_fit;fi;run findfdt; run finduuid; run
distro_bootcmd;run emmc_android_boot; "
am65x_evm_a53_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd;
run init_${boot}; run boot_rprocs; if test ${boot_fit} -eq 1; then run
get_fit_${boot}; run get_overlaystring; run run_fit; else; run
get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern;
fi;"
dra7xx_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then echo
Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
1; then run update_to_fit;fi;run findfdt; run finduuid; run distro_bootcmd;run
emmc_android_boot; "
dra7xx_hs_evm_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1; then
echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot 0;
saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit} -eq
1; then run update_to_fit;fi;run findfdt; run finduuid; run distro_bootcmd;run
emmc_android_boot; "
dra7xx_hs_evm_usb_defconfig:CONFIG_BOOTCOMMAND="if test ${dofastboot} -eq 1;
then echo Boot fastboot requested, resetting dofastboot ...;setenv dofastboot
0; saveenv;echo Booting into fastboot ...; fastboot 1;fi;if test ${boot_fit}
-eq 1; then run update_to_fit;fi;run findfdt; run finduuid; run
distro_bootcmd;run emmc_android_boot; "
k2g_evm_defconfig:CONFIG_BOOTCOMMAND="run findfdt; run envboot; run
init_${boot}; run get_mon_${boot} run_mon; run set_name_pmmc get_pmmc_${boot}
run_pmmc; run get_kern_${boot}; run
[PATCH V2 10/10] include: env: ti: Drop default_findfdt
We shouldn't need finfdt anymore. Drop the env script.
Signed-off-by: Nishanth Menon
---
Changes from V1: None.
V1: https://lore.kernel.org/r/20240108173301.2692332-11...@ti.com
include/env/ti/default_findfdt.env | 12
1 file changed, 12 deletions(-)
delete mode 100644 include/env/ti/default_findfdt.env
diff --git a/include/env/ti/default_findfdt.env
b/include/env/ti/default_findfdt.env
deleted file mode 100644
index a2b51dd923bb..
--- a/include/env/ti/default_findfdt.env
+++ /dev/null
@@ -1,12 +0,0 @@
-default_device_tree=CONFIG_DEFAULT_DEVICE_TREE
-default_device_tree_arch=ti
-#ifdef CONFIG_ARM64
-findfdt=
- setenv name_fdt ${default_device_tree_arch}/${default_device_tree}.dtb;
- setenv fdtfile ${name_fdt}
-#else
-default_device_tree_subarch=omap
-findfdt=
- setenv name_fdt
${default_device_tree_arch}/${default_device_tree_subarch}/${default_device_tree}.dtb;
- setenv fdtfile ${name_fdt}
-#endif
--
2.43.0
