Re: [PATCH resend 1/2] gpio: mpc8xxx: don't modify gpdat when setting gpio as input

2020-03-31 Thread Tom Rini
On Tue, Jan 28, 2020 at 12:04:33PM +, Rasmus Villemoes wrote: > Since some chips don't support reading back the value of output gpios > from the gpdat register, we should not do a RMW cycle (i.e., the > clrbits_be32) on the gpdat register when setting a gpio as input, as > that might

[PATCH resend 1/2] gpio: mpc8xxx: don't modify gpdat when setting gpio as input

2020-01-28 Thread Rasmus Villemoes
Since some chips don't support reading back the value of output gpios from the gpdat register, we should not do a RMW cycle (i.e., the clrbits_be32) on the gpdat register when setting a gpio as input, as that might accidentally change the value of some other (still configured as output) gpio. The