Re: [PATCH v1] doc: board: colibri-imx8x: Update and improve documentation

2024-03-15 Thread Fabio Estevam 
Hi Hiago,

On Fri, Mar 15, 2024 at 11:39 AM Hiago De Franco  wrote:
>
> From: Hiago De Franco 
>
> Update and improve the building documentation of Colibri iMX8X.
> The following changes were made:
> - imx-atf repository changed to nxp-imx GitHub.
> - imx-atf branch updated to 'lf_v2.6'.
> - imx-seco updated to version 5.8.7.
> - nxp-imx mfgtools link updated to GitHub releases.
> - General writing improvements.

Thanks for improving the documentation.

One minor suggestion.

I have recently followed this document and noticed that the
instruction to copy the
mx8qm-apalis-scfw-tcm.bin to the U-Boot source is missing. Please add it.

Also, since you are updating several components, shouldn't
mx8qm-apalis-scfw-tcm.bin be updated?

Currently, the version is from toradex-sumo-4.14.78-1.0.0_ga-bringup
which looks quite ancient.

Re: [PATCH v1] doc: board: colibri-imx8x: Update and improve documentation

2024-03-15 Thread Francesco Dolcini 
On Fri, Mar 15, 2024 at 11:39:30AM -0300, Hiago De Franco wrote:
> From: Hiago De Franco 
> 
> Update and improve the building documentation of Colibri iMX8X.
> The following changes were made:
> - imx-atf repository changed to nxp-imx GitHub.
> - imx-atf branch updated to 'lf_v2.6'.
> - imx-seco updated to version 5.8.7.
> - nxp-imx mfgtools link updated to GitHub releases.
> - General writing improvements.
> 
> Signed-off-by: Hiago De Franco 

Reviewed-by: Francesco Dolcini 

Francesco