Re: [PATCH v1 02/43] binman: Refactor binman_entry_find() to allow other nodes

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 12:07:24PM +0800, Bin Meng wrote: > +Tom, > > On Wed, Jul 8, 2020 at 10:23 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Mon, 29 Jun 2020 at 20:33, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > > > > > At

Re: [PATCH v1 02/43] binman: Refactor binman_entry_find() to allow other nodes

2020-07-07 Thread Bin Meng
+Tom, On Wed, Jul 8, 2020 at 10:23 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 29 Jun 2020 at 20:33, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > > > At present we can only read from a top-level binman node entry. Refactor > > > this fu

Re: [PATCH v1 02/43] binman: Refactor binman_entry_find() to allow other nodes

2020-07-07 Thread Simon Glass
Hi Bin, On Mon, 29 Jun 2020 at 20:33, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > At present we can only read from a top-level binman node entry. Refactor > > this function to produce a second local function which supports reading > > from any no

Re: [PATCH v1 02/43] binman: Refactor binman_entry_find() to allow other nodes

2020-06-29 Thread Bin Meng
Hi Simon, On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > At present we can only read from a top-level binman node entry. Refactor > this function to produce a second local function which supports reading > from any node. > > Signed-off-by: Simon Glass > --- > > lib/binman.c | 18 ++

[PATCH v1 02/43] binman: Refactor binman_entry_find() to allow other nodes

2020-06-14 Thread Simon Glass
At present we can only read from a top-level binman node entry. Refactor this function to produce a second local function which supports reading from any node. Signed-off-by: Simon Glass --- lib/binman.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/lib