Re: [PATCH v1 6/6] spinand: bind UBI block

2024-03-22 Thread Heiko Schocher

Hello Alexey,

On 06.03.24 14:49, Alexey Romanov wrote:

UBI block is virtual block device, which is an abstraction
over MTD layer. Therefore it is logical to use it in combination
with MTD drivers.

Signed-off-by: Alexey Romanov 
---
  drivers/mtd/nand/spi/core.c | 9 -
  1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index f2ec32e1d0..32705e1e2a 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -27,6 +27,7 @@
  #include 
  #include 
  #include 
+#include 
  #include 
  #include 
  #include 
@@ -1182,7 +1183,13 @@ static void spinand_cleanup(struct spinand_device 
*spinand)
  static int spinand_bind(struct udevice *dev)
  {
struct spinand_plat *plat = dev_get_plat(dev);
-   return mtd_bind(dev, >mtd);
+   int ret;
+
+   ret = mtd_bind(dev, >mtd);
+   if (ret)
+   return ret;
+
+   return ubi_bind(dev);


What is with boards which do not use ubi block or CONFIG_BLK at all?

bye,
Heiko
--
--
DENX Software Engineering GmbH,  Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de


[PATCH v1 6/6] spinand: bind UBI block

2024-03-06 Thread Alexey Romanov
UBI block is virtual block device, which is an abstraction
over MTD layer. Therefore it is logical to use it in combination
with MTD drivers.

Signed-off-by: Alexey Romanov 
---
 drivers/mtd/nand/spi/core.c | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index f2ec32e1d0..32705e1e2a 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1182,7 +1183,13 @@ static void spinand_cleanup(struct spinand_device 
*spinand)
 static int spinand_bind(struct udevice *dev)
 {
struct spinand_plat *plat = dev_get_plat(dev);
-   return mtd_bind(dev, >mtd);
+   int ret;
+
+   ret = mtd_bind(dev, >mtd);
+   if (ret)
+   return ret;
+
+   return ubi_bind(dev);
 }
 #endif
 
-- 
2.34.1