Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-10-10 Thread Bin Meng
On Fri, Sep 17, 2021 at 2:52 PM Rick Chen wrote: > > > From: Bin Meng > > Sent: Saturday, September 11, 2021 10:31 PM > > To: Zong Li ; Leo Yu-Chi Liang(梁育齊) > > ; Rick Jian-Zhi Chen(陳建志) ; > > u-boot@lists.denx.de > > Subject: [PATCH v2] board

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-29 Thread Ilias Apalodimas
[...] > > > int board_init(void) > > > diff --git a/board/sifive/unmatched/unmatched.c > > > b/board/sifive/unmatched/unmatched.c > > > index d90b252bae..8773b660fa 100644 > > > --- a/board/sifive/unmatched/unmatched.c > > > +++ b/board/sifive/unmatched/unmatched.c > > > @@ -16,9 +16,9 @@ void

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-29 Thread Bin Meng
Hi Ilias, On Wed, Sep 29, 2021 at 9:07 PM Ilias Apalodimas wrote: > > Hi Bin > > There's a similar discussion in a cleanup series I've sent [1] > On Sat, Sep 11, 2021 at 10:31:23PM +0800, Bin Meng wrote: > > Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in > > u-boot

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-29 Thread Ilias Apalodimas
Hi Bin There's a similar discussion in a cleanup series I've sent [1] On Sat, Sep 11, 2021 at 10:31:23PM +0800, Bin Meng wrote: > Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in u-boot > proper") > added a board-specific implementation of board_fdt_blob_setup() which >

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-17 Thread Rick Chen
> From: Bin Meng > Sent: Saturday, September 11, 2021 10:31 PM > To: Zong Li ; Leo Yu-Chi Liang(梁育齊) > ; Rick Jian-Zhi Chen(陳建志) ; > u-boot@lists.denx.de > Subject: [PATCH v2] board: sifive: Fix a potential build warning in > board_fdt_blob_setup() > > Commit 4

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-14 Thread Leo Liang
On Sat, Sep 11, 2021 at 10:31:23PM +0800, Bin Meng wrote: > Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in u-boot > proper") > added a board-specific implementation of board_fdt_blob_setup() which > takes a pointer as the return value, but it does not return anything > if

[PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-11 Thread Bin Meng
Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in u-boot proper") added a board-specific implementation of board_fdt_blob_setup() which takes a pointer as the return value, but it does not return anything if CONFIG_OF_SEPARATE is not enabled. This will cause a build warning