Re: [PATCH v2] cmd: mmc: add mmcboot command

2021-01-07 Thread Ravik Hasija
> I think that it's not good about building disk.c by default when CONFIG_CMD_MMC is enabled. Agree, its not an optimal solution. However, we chose to do it this way because: - It causes minimal change to the size of binary (~200 bytes). - To be consistent with upstream code where it is built

Re: [PATCH v2] cmd: mmc: add mmcboot command

2021-01-05 Thread Ravik Hasija
> Can this not be implemented by some U-Boot script ? > I can imagine that reading the first few bytes from the partition (mmc > read) would permit you to obtain the uImage/fitImage header from the > partition, from which you can obtain the image size, which is the total > number of bytes to read

Re: [PATCH v2] cmd: mmc: add mmcboot command

2021-01-04 Thread Jaehoon Chung
On 1/5/21 3:40 AM, Ravik Hasija wrote: > Similar to usbboot, add command line to boot from raw mmc partition > using common_diskboot(), which supports legacy or FIT images. > > Usage: > mmcboot [loadAaddr] [dev:part] > > Where [loadAddr] defaults to CONFIG_SYS_LOAD_ADDR, and [dev:part] >

Re: [PATCH v2] cmd: mmc: add mmcboot command

2021-01-04 Thread Marek Vasut
On 1/4/21 7:40 PM, Ravik Hasija wrote: Similar to usbboot, add command line to boot from raw mmc partition using common_diskboot(), which supports legacy or FIT images. Usage: mmcboot [loadAaddr] [dev:part] Where [loadAddr] defaults to CONFIG_SYS_LOAD_ADDR, and [dev:part] defaults to

[PATCH v2] cmd: mmc: add mmcboot command

2021-01-04 Thread Ravik Hasija
Similar to usbboot, add command line to boot from raw mmc partition using common_diskboot(), which supports legacy or FIT images. Usage: mmcboot [loadAaddr] [dev:part] Where [loadAddr] defaults to CONFIG_SYS_LOAD_ADDR, and [dev:part] defaults to ${bootdevice}. Also fixing config macro usage for