Re: [PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-06-04 Thread Ramon Fried
On Fri, Jun 3, 2022 at 10:49 PM Tom Rini wrote: > > On Thu, May 26, 2022 at 11:14:37AM -0300, Fabio Estevam wrote: > > > From: Fabio Estevam > > > > Nicolas Bidron and Nicolas Guigo reported the two bugs below: > > > > " > > Applied to u-boot/master, thanks! > > -- > Tom Thanks Tom, Just came

Re: [PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-06-03 Thread Tom Rini
On Thu, May 26, 2022 at 11:14:37AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Nicolas Bidron and Nicolas Guigo reported the two bugs below: > > " Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-05-26 Thread Fabio Estevam
On Thu, May 26, 2022 at 1:10 PM Fabio Estevam wrote: > > On 26/05/2022 11:14, Fabio Estevam wrote: > > > Add a check for ip_len lesser than 28 and stop processing the packet > > in this case. > > > > Such a check covers the two reported bugs. > > Ops, it is (ip->ip_len < 21) the condition that

Re: [PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-05-26 Thread Fabio Estevam
On 26/05/2022 11:14, Fabio Estevam wrote: Add a check for ip_len lesser than 28 and stop processing the packet in this case. Such a check covers the two reported bugs. Ops, it is (ip->ip_len < 21) the condition that satisfies both cases. I will send a v3.

[PATCH v2] net: Check for the minimum IP fragmented datagram size

2022-05-26 Thread Fabio Estevam
From: Fabio Estevam Nicolas Bidron and Nicolas Guigo reported the two bugs below: " --BUG 1-- In compiled versions of U-Boot that define CONFIG_IP_DEFRAG, a value of `ip->ip_len` (IP packet header's Total Length) higher than `IP_HDR_SIZE` and strictly lower than `IP_HDR_SIZE+8`