Re: [PATCH v2] spi: spi-mem: ease checks in dtr_supports_op()

2022-11-11 Thread Pratyush Yadav
On 07/11/22 06:46PM, Gole, Dhruva wrote: > Hey Pratyush, > > On 11/7/2022 4:16 AM, Pratyush Yadav wrote: > > Hi Dhruva :-) > > > > On 25/10/22 11:50AM, Dhruva Gole wrote: > > > Remove the extra conditions that cause some cases to fail prematurely > > > like if the data number of bytes is odd.

Re: [PATCH v2] spi: spi-mem: ease checks in dtr_supports_op()

2022-11-07 Thread Gole, Dhruva
Hey Pratyush, On 11/7/2022 4:16 AM, Pratyush Yadav wrote: Hi Dhruva :-) On 25/10/22 11:50AM, Dhruva Gole wrote: Remove the extra conditions that cause some cases to fail prematurely like if the data number of bytes is odd. The controller can handle odd First, some background on why I added

Re: [PATCH v2] spi: spi-mem: ease checks in dtr_supports_op()

2022-11-07 Thread Pratyush Yadav
Hi Dhruva :-) On 25/10/22 11:50AM, Dhruva Gole wrote: > Remove the extra conditions that cause some cases to fail prematurely > like if the data number of bytes is odd. The controller can handle odd First, some background on why I added this in the first place. In 1S-1S-1S mode, it takes 8

Re: [PATCH v2] spi: spi-mem: ease checks in dtr_supports_op()

2022-10-27 Thread Dhruva Gole
Hi, A gentle reminder to review the following patch: spi: spi-mem: ease checks in dtr_supports_op() https://lore.kernel.org/u-boot/20221025062036.383460-1-d-g...@ti.com/ Kindly merge if it looks okay. On 25/10/22 11:50, Dhruva Gole wrote: Remove the extra conditions that cause some cases to

[PATCH v2] spi: spi-mem: ease checks in dtr_supports_op()

2022-10-25 Thread Dhruva Gole
Remove the extra conditions that cause some cases to fail prematurely like if the data number of bytes is odd. The controller can handle odd number of bytes data read in DTR Mode. Don't fail supports op for this condition. This change can also be justified by taking a look at the equivalent code