Re: [PATCH v2 0/4] usb: xhci: Prepare xHCI driver for MIPS Octeon big-endian support
On 8/5/20 7:57 AM, Stefan Roese wrote: > Hi Marek, > > On 30.07.20 08:59, Bin Meng wrote: >> Hi Marek, >> >> On Thu, Jul 30, 2020 at 2:32 PM Stefan Roese wrote: >>> >>> Hi Bin, >>> >>> On 21.07.20 10:46, Stefan Roese wrote: These patches fix a few issues, found while porting the xHCI to the MIPS Octeon platforms. The basic issues here are: - Endianess issues: missing cpu_to_leXX() & leXX_to_cpu() conversions - Use physical (DMA) address for the xHCI DMA controller These patches are the groundwork for the upcoming xHCI Octeon support that will follow soon. Thanks, Stefan Changes in v2: - Add missing (uintptr_t) cast to remove compile time warning Stefan Roese (4): usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu) usb: xhci: xhci_mem_init: Use cpu_to_le64() and not xhci_writeq() usb: usb-uclass.c: Drop le16_to_cpu() as values are already swapped usb: xhci: Add virt_to_phys() to support mapped platforms drivers/usb/host/usb-uclass.c | 8 drivers/usb/host/xhci-mem.c | 30 +++--- drivers/usb/host/xhci-ring.c | 8 drivers/usb/host/xhci.c | 3 +-- 4 files changed, 24 insertions(+), 25 deletions(-) >>> >>> Is everything okay with this series? If yes, I think it would be good to >>> have it included soon into mainline, so that all platforms have time to >>> test these changes to the common xHCI driver. >> >> Would you pick up this series? Or do you want me to pick this up via >> u-boot-x86 tree? > > Gently ping on this. Applied, thanks.
Re: [PATCH v2 0/4] usb: xhci: Prepare xHCI driver for MIPS Octeon big-endian support
Hi Marek, On 30.07.20 08:59, Bin Meng wrote: Hi Marek, On Thu, Jul 30, 2020 at 2:32 PM Stefan Roese wrote: Hi Bin, On 21.07.20 10:46, Stefan Roese wrote: These patches fix a few issues, found while porting the xHCI to the MIPS Octeon platforms. The basic issues here are: - Endianess issues: missing cpu_to_leXX() & leXX_to_cpu() conversions - Use physical (DMA) address for the xHCI DMA controller These patches are the groundwork for the upcoming xHCI Octeon support that will follow soon. Thanks, Stefan Changes in v2: - Add missing (uintptr_t) cast to remove compile time warning Stefan Roese (4): usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu) usb: xhci: xhci_mem_init: Use cpu_to_le64() and not xhci_writeq() usb: usb-uclass.c: Drop le16_to_cpu() as values are already swapped usb: xhci: Add virt_to_phys() to support mapped platforms drivers/usb/host/usb-uclass.c | 8 drivers/usb/host/xhci-mem.c | 30 +++--- drivers/usb/host/xhci-ring.c | 8 drivers/usb/host/xhci.c | 3 +-- 4 files changed, 24 insertions(+), 25 deletions(-) Is everything okay with this series? If yes, I think it would be good to have it included soon into mainline, so that all platforms have time to test these changes to the common xHCI driver. Would you pick up this series? Or do you want me to pick this up via u-boot-x86 tree? Gently ping on this. Thanks, Stefan
Re: [PATCH v2 0/4] usb: xhci: Prepare xHCI driver for MIPS Octeon big-endian support
Hi Marek, On Thu, Jul 30, 2020 at 2:32 PM Stefan Roese wrote: > > Hi Bin, > > On 21.07.20 10:46, Stefan Roese wrote: > > > > These patches fix a few issues, found while porting the xHCI to the MIPS > > Octeon platforms. The basic issues here are: > > > > - Endianess issues: missing cpu_to_leXX() & leXX_to_cpu() conversions > > - Use physical (DMA) address for the xHCI DMA controller > > > > These patches are the groundwork for the upcoming xHCI Octeon support > > that will follow soon. > > > > Thanks, > > Stefan > > > > Changes in v2: > > - Add missing (uintptr_t) cast to remove compile time warning > > > > Stefan Roese (4): > >usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu) > >usb: xhci: xhci_mem_init: Use cpu_to_le64() and not xhci_writeq() > >usb: usb-uclass.c: Drop le16_to_cpu() as values are already swapped > >usb: xhci: Add virt_to_phys() to support mapped platforms > > > > drivers/usb/host/usb-uclass.c | 8 > > drivers/usb/host/xhci-mem.c | 30 +++--- > > drivers/usb/host/xhci-ring.c | 8 > > drivers/usb/host/xhci.c | 3 +-- > > 4 files changed, 24 insertions(+), 25 deletions(-) > > > > Is everything okay with this series? If yes, I think it would be good to > have it included soon into mainline, so that all platforms have time to > test these changes to the common xHCI driver. Would you pick up this series? Or do you want me to pick this up via u-boot-x86 tree? Regards, Bin
Re: [PATCH v2 0/4] usb: xhci: Prepare xHCI driver for MIPS Octeon big-endian support
Hi Bin, On 21.07.20 10:46, Stefan Roese wrote: These patches fix a few issues, found while porting the xHCI to the MIPS Octeon platforms. The basic issues here are: - Endianess issues: missing cpu_to_leXX() & leXX_to_cpu() conversions - Use physical (DMA) address for the xHCI DMA controller These patches are the groundwork for the upcoming xHCI Octeon support that will follow soon. Thanks, Stefan Changes in v2: - Add missing (uintptr_t) cast to remove compile time warning Stefan Roese (4): usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu) usb: xhci: xhci_mem_init: Use cpu_to_le64() and not xhci_writeq() usb: usb-uclass.c: Drop le16_to_cpu() as values are already swapped usb: xhci: Add virt_to_phys() to support mapped platforms drivers/usb/host/usb-uclass.c | 8 drivers/usb/host/xhci-mem.c | 30 +++--- drivers/usb/host/xhci-ring.c | 8 drivers/usb/host/xhci.c | 3 +-- 4 files changed, 24 insertions(+), 25 deletions(-) Is everything okay with this series? If yes, I think it would be good to have it included soon into mainline, so that all platforms have time to test these changes to the common xHCI driver. Thanks, Stefan
[PATCH v2 0/4] usb: xhci: Prepare xHCI driver for MIPS Octeon big-endian support
These patches fix a few issues, found while porting the xHCI to the MIPS Octeon platforms. The basic issues here are: - Endianess issues: missing cpu_to_leXX() & leXX_to_cpu() conversions - Use physical (DMA) address for the xHCI DMA controller These patches are the groundwork for the upcoming xHCI Octeon support that will follow soon. Thanks, Stefan Changes in v2: - Add missing (uintptr_t) cast to remove compile time warning Stefan Roese (4): usb: xhci: Add missing endian conversions (cpu_to_leXX / leXX_to_cpu) usb: xhci: xhci_mem_init: Use cpu_to_le64() and not xhci_writeq() usb: usb-uclass.c: Drop le16_to_cpu() as values are already swapped usb: xhci: Add virt_to_phys() to support mapped platforms drivers/usb/host/usb-uclass.c | 8 drivers/usb/host/xhci-mem.c | 30 +++--- drivers/usb/host/xhci-ring.c | 8 drivers/usb/host/xhci.c | 3 +-- 4 files changed, 24 insertions(+), 25 deletions(-) -- 2.27.0