Re: [PATCH v2 00/18] am335x, guardian: update board specific changes

2021-05-27 Thread Lokesh Vutla
Hi Gireesh,

On 22/04/21 7:01 pm, gireesh.hirem...@in.bosch.com wrote:
> From: Gireesh Hiremath 
> 
> add support for updated TI clock driver, backlight, splash screen,
> swi logic, add ubi fastmap support, update pinmux, code clean up
> 
> address the v1 review comments like:
> split board changes and defconfig changes into separate patches,
> adding clock support

Overall looks good. Just minor comments:
- For config file changes can you make $subject as
configs: am335x_guardian: ...
- Can you rebase on top of latest master?

Thanks and regards,
Lokesh

> 
> Gireesh Hiremath (15):
>   am335x, guardian: configs: Enable clock driver for guardian
>   am335x, guardian: configs: add ubi fastmap support
>   am335x, guardian: configs: cmd: add memtest configs
>   am335x, guardian: add memtest address range
>   am335x, guardian: set environment variable autoload to no
>   am335x, guardian: code cleanup and boot optimization
>   am335x, guardian: configs: set boot delay
>   am335x, guardian: configs: cmd : disable spl command
>   am335x, guardian: update swi logic
>   am335x, guardian: Enable backlight
>   am335x, guardian: configs: Enable display config
>   drivers: video: hx8238 fix build bug
>   am335x, guardian: Enable panel driver Himax HX8238D
>   am335x, guardian: software update available status is stored in AM3352
> RTC scracth register
>   am335x, guardian: configs: Enable bootcount nvmem support
> 
> Moses Christopher (3):
>   am335x, guardian: mem: Add board dependent mem values
>   am335x, guardian: set tftp_load_addr in environment
>   am335x, guardian: Update pinmux configuration
> 
>  arch/arm/dts/am335x-guardian-u-boot.dtsi  |  11 ++
>  arch/arm/dts/am335x-guardian.dts  |  14 +-
>  .../include/asm/arch-am33xx/mem-guardian.h|  63 
>  arch/arm/mach-omap2/am33xx/Kconfig|   2 +
>  arch/arm/mach-omap2/am33xx/board.c|   4 +
>  arch/arm/mach-omap2/mem-common.c  |   4 +
>  board/bosch/guardian/board.c  | 151 +++---
>  board/bosch/guardian/mux.c|   3 +-
>  configs/am335x_guardian_defconfig |  27 +++-
>  drivers/bootcount/Kconfig |  27 +++-
>  drivers/bootcount/Makefile|   1 +
>  drivers/bootcount/bootcount_nvmem.c   |  57 +++
>  drivers/video/Makefile|   2 +-
>  drivers/video/hx8238d.c   |   4 +-
>  include/configs/am335x_guardian.h |  21 ++-
>  15 files changed, 349 insertions(+), 42 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-am33xx/mem-guardian.h
>  create mode 100644 drivers/bootcount/bootcount_nvmem.c
> 


[PATCH v2 00/18] am335x, guardian: update board specific changes

2021-04-22 Thread Gireesh.Hiremath
From: Gireesh Hiremath 

add support for updated TI clock driver, backlight, splash screen,
swi logic, add ubi fastmap support, update pinmux, code clean up

address the v1 review comments like:
split board changes and defconfig changes into separate patches,
adding clock support

Gireesh Hiremath (15):
  am335x, guardian: configs: Enable clock driver for guardian
  am335x, guardian: configs: add ubi fastmap support
  am335x, guardian: configs: cmd: add memtest configs
  am335x, guardian: add memtest address range
  am335x, guardian: set environment variable autoload to no
  am335x, guardian: code cleanup and boot optimization
  am335x, guardian: configs: set boot delay
  am335x, guardian: configs: cmd : disable spl command
  am335x, guardian: update swi logic
  am335x, guardian: Enable backlight
  am335x, guardian: configs: Enable display config
  drivers: video: hx8238 fix build bug
  am335x, guardian: Enable panel driver Himax HX8238D
  am335x, guardian: software update available status is stored in AM3352
RTC scracth register
  am335x, guardian: configs: Enable bootcount nvmem support

Moses Christopher (3):
  am335x, guardian: mem: Add board dependent mem values
  am335x, guardian: set tftp_load_addr in environment
  am335x, guardian: Update pinmux configuration

 arch/arm/dts/am335x-guardian-u-boot.dtsi  |  11 ++
 arch/arm/dts/am335x-guardian.dts  |  14 +-
 .../include/asm/arch-am33xx/mem-guardian.h|  63 
 arch/arm/mach-omap2/am33xx/Kconfig|   2 +
 arch/arm/mach-omap2/am33xx/board.c|   4 +
 arch/arm/mach-omap2/mem-common.c  |   4 +
 board/bosch/guardian/board.c  | 151 +++---
 board/bosch/guardian/mux.c|   3 +-
 configs/am335x_guardian_defconfig |  27 +++-
 drivers/bootcount/Kconfig |  27 +++-
 drivers/bootcount/Makefile|   1 +
 drivers/bootcount/bootcount_nvmem.c   |  57 +++
 drivers/video/Makefile|   2 +-
 drivers/video/hx8238d.c   |   4 +-
 include/configs/am335x_guardian.h |  21 ++-
 15 files changed, 349 insertions(+), 42 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-am33xx/mem-guardian.h
 create mode 100644 drivers/bootcount/bootcount_nvmem.c

-- 
2.20.1