Convert the long line of if() statements to a switch() since this makes
better use of the C language.

Signed-off-by: Simon Glass <s...@chromium.org>
---

(no changes since v1)

 common/menu.c | 31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/common/menu.c b/common/menu.c
index 6842f5409d6..7db98942a61 100644
--- a/common/menu.c
+++ b/common/menu.c
@@ -543,22 +543,31 @@ enum bootmenu_key bootmenu_loop(struct bootmenu_data 
*menu, int *esc)
                break;
        }
 
-       /* enter key was pressed */
-       if (c == '\r')
+       switch (c) {
+       case '\r':
+               /* enter key was pressed */
                key = BKEY_SELECT;
-
-       /* ^C was pressed */
-       if (c == 0x3)
+               break;
+       case CTL_CH('c'):
+               /* ^C was pressed */
                key = BKEY_QUIT;
-
-       if (c == '+')
+               break;
+       case CTL_CH('p'):
+               key = BKEY_UP;
+               break;
+       case CTL_CH('n'):
+               key = BKEY_DOWN;
+               break;
+       case '+':
                key = BKEY_PLUS;
-
-       if (c == '-')
+               break;
+       case '-':
                key = BKEY_MINUS;
-
-       if (c == ' ')
+               break;
+       case ' ':
                key = BKEY_SPACE;
+               break;
+       }
 
        return key;
 }
-- 
2.38.1.431.g37b22c650d-goog

Reply via email to