Re: [PATCH v2 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

[Fabio Estevam]

On Mon, Mar 4, 2024 at 1:04 PM Benjamin Hahn  wrote:

> +enum phytec_som_type_str {
> +   PCM = 0,
> +   PCL,
> +   KSM,
> +   KSP,
> +};

To avoid potential name clashes in the future, I suggest adding a prefix like:

SOM_TYPE_PCM = 0,
SOM_TYPE_PCL,
...




> +
>  static const char * const phytec_som_type_str[] = {
> "PCM",
> "PCL",
> @@ -67,5 +74,6 @@ void __maybe_unused phytec_print_som_info(struct 
> phytec_eeprom_data *data);
>
>  char * __maybe_unused phytec_get_opt(struct phytec_eeprom_data *data);
>  u8 __maybe_unused phytec_get_rev(struct phytec_eeprom_data *data);
> +u8 __maybe_unused phytec_get_som_type(struct phytec_eeprom_data *data);
>
>  #endif /* _PHYTEC_SOM_DETECTION_H */
>
> --
> 2.34.1
>

[PATCH v2 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

[Benjamin Hahn]

Add a function that gets the som_type from the EEPROM.
Add an enum for the som_type.

Signed-off-by: Benjamin Hahn 
---
 board/phytec/common/phytec_som_detection.c | 10 ++
 board/phytec/common/phytec_som_detection.h |  8 
 2 files changed, 18 insertions(+)

diff --git a/board/phytec/common/phytec_som_detection.c 
b/board/phytec/common/phytec_som_detection.c
index c73bf9721b2f..f9607b018dea 100644
--- a/board/phytec/common/phytec_som_detection.c
+++ b/board/phytec/common/phytec_som_detection.c
@@ -203,6 +203,16 @@ u8 __maybe_unused phytec_get_rev(struct phytec_eeprom_data 
*data)
return api2->pcb_rev;
 }
 
+u8 __maybe_unused phytec_get_som_type(struct phytec_eeprom_data *data)
+{
+   if (!data)
+   data = _data;
+   if (data->api_rev < PHYTEC_API_REV2)
+   return PHYTEC_EEPROM_INVAL;
+
+   return data->data.data_api2.som_type;
+}
+
 #else
 
 inline int phytec_eeprom_data_setup(struct phytec_eeprom_data *data,
diff --git a/board/phytec/common/phytec_som_detection.h 
b/board/phytec/common/phytec_som_detection.h
index 11009240875c..c0f0c57a6123 100644
--- a/board/phytec/common/phytec_som_detection.h
+++ b/board/phytec/common/phytec_som_detection.h
@@ -19,6 +19,13 @@ enum {
PHYTEC_API_REV2,
 };
 
+enum phytec_som_type_str {
+   PCM = 0,
+   PCL,
+   KSM,
+   KSP,
+};
+
 static const char * const phytec_som_type_str[] = {
"PCM",
"PCL",
@@ -67,5 +74,6 @@ void __maybe_unused phytec_print_som_info(struct 
phytec_eeprom_data *data);
 
 char * __maybe_unused phytec_get_opt(struct phytec_eeprom_data *data);
 u8 __maybe_unused phytec_get_rev(struct phytec_eeprom_data *data);
+u8 __maybe_unused phytec_get_som_type(struct phytec_eeprom_data *data);
 
 #endif /* _PHYTEC_SOM_DETECTION_H */

-- 
2.34.1