Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-09-23 Thread Rasmus Villemoes
On 20/05/2020 00.12, Rasmus Villemoes wrote: > On 20/03/2020 11.14, Rasmus Villemoes wrote: >> I have a board for which doing "sf erase 0x10 0x8" >> consistently causes the external watchdog circuit to reset the >> board. Make sure to pet the watchdog during slow operations such as >>

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-05-19 Thread Rasmus Villemoes
On 20/03/2020 11.14, Rasmus Villemoes wrote: > I have a board for which doing "sf erase 0x10 0x8" > consistently causes the external watchdog circuit to reset the > board. Make sure to pet the watchdog during slow operations such as > erasing or writing large areas of a spi nor flash.

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-03-26 Thread Wolfgang Denk
Dear Vignesh, In message <9a1e75ac-135a-26aa-2ded-784fbe14b...@ti.com> you wrote: > > I fully understand your concerns and will work on unifying the two > stacks with IS_ENABLED() macro so that there will still be a tiny stack > with same memory footprint. Thanks!! > But I want to state that

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-03-26 Thread Vignesh Raghavendra
On 24/03/20 8:11 pm, Wolfgang Denk wrote: > Dear Vignesh, > > In message <05694b0e-50a1-de5d-25d8-0444a2cae...@ti.com> you wrote: >> >> Aim of spi-nor-tiny.c is to have a tiny stack that can be used in >> SPL/TPL or on resource constraint boards to only support _reading_ from >> the flash. So

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-03-24 Thread Wolfgang Denk
Dear Vignesh, In message <05694b0e-50a1-de5d-25d8-0444a2cae...@ti.com> you wrote: > > Aim of spi-nor-tiny.c is to have a tiny stack that can be used in > SPL/TPL or on resource constraint boards to only support _reading_ from > the flash. So tiny stack would be subset of spi-nor-core. I fully

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-03-24 Thread Vignesh Raghavendra
Dear Wolfgang, On 20/03/20 4:48 pm, Wolfgang Denk wrote: > Dear Vignesh, > > In message <20200320101448.10714-1-rasmus.villem...@prevas.dk> Rasmus > Villemoes wrote: >> I have a board for which doing "sf erase 0x10 0x8" >> consistently causes the external watchdog circuit to reset the

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-03-20 Thread Wolfgang Denk
Dear Vignesh, In message <20200320101448.10714-1-rasmus.villem...@prevas.dk> Rasmus Villemoes wrote: > I have a board for which doing "sf erase 0x10 0x8" > consistently causes the external watchdog circuit to reset the > board. Make sure to pet the watchdog during slow operations such as

[PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-03-20 Thread Rasmus Villemoes
I have a board for which doing "sf erase 0x10 0x8" consistently causes the external watchdog circuit to reset the board. Make sure to pet the watchdog during slow operations such as erasing or writing large areas of a spi nor flash. Signed-off-by: Rasmus Villemoes ---