Re: [PATCH v2 10/14] stm32mp: activate the command stboard for stm32mp25 boards

2024-01-15 Thread Patrice CHOTARD 



On 1/15/24 15:05, Patrick Delaunay wrote:
> Activate the command stboard for stm32mp25 STMicroelectronics boards,
> add the default used OTP identifier and the associated board identifier:
> - stm32mp25xx-ev1 = MB1936
> - stm32mp25xx-dk = MB1605
> 
> Signed-off-by: Patrick Delaunay 
> ---
> 
> Changes in v2:
> - fix CONFIG name with 'x': TARGET_ST_STM32MP15x TARGET_ST_STM32MP13x
> 
>  arch/arm/mach-stm32mp/include/mach/stm32.h | 1 +
>  board/st/common/Kconfig| 2 +-
>  board/st/common/cmd_stboard.c  | 2 ++
>  3 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h 
> b/arch/arm/mach-stm32mp/include/mach/stm32.h
> index 45c929aa605d..726c390977e3 100644
> --- a/arch/arm/mach-stm32mp/include/mach/stm32.h
> +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h
> @@ -198,6 +198,7 @@ enum forced_boot_mode {
>  #define BSEC_OTP_SERIAL  5
>  #define BSEC_OTP_RPN 9
>  #define BSEC_OTP_PKG 122
> +#define BSEC_OTP_BOARD   246
>  #define BSEC_OTP_MAC 247
>  #endif
>  
> diff --git a/board/st/common/Kconfig b/board/st/common/Kconfig
> index c1c254d07354..f40d1a78ca36 100644
> --- a/board/st/common/Kconfig
> +++ b/board/st/common/Kconfig
> @@ -1,7 +1,7 @@
>  config CMD_STBOARD
>   bool "stboard - command for OTP board information"
>   depends on ARCH_STM32MP
> - default y if TARGET_ST_STM32MP15x || TARGET_ST_STM32MP13x
> + default y if TARGET_ST_STM32MP25X || TARGET_ST_STM32MP15x || 
> TARGET_ST_STM32MP13x
>   help
> This compile the stboard command to
> read and write the board in the OTP.
> diff --git a/board/st/common/cmd_stboard.c b/board/st/common/cmd_stboard.c
> index 853ab78bbf16..cb103e69b369 100644
> --- a/board/st/common/cmd_stboard.c
> +++ b/board/st/common/cmd_stboard.c
> @@ -49,7 +49,9 @@ static bool check_stboard(u16 board)
>   0x1298,
>   0x1341,
>   0x1497,
> + 0x1605, /* stm32mp25xx-dk */
>   0x1635,
> + 0x1936, /* stm32mp25xx-ev1 */
>   };
>  
>   for (i = 0; i < ARRAY_SIZE(st_board_id); i++)
Reviewed-by: Patrice Chotard 

Thanks

[PATCH v2 10/14] stm32mp: activate the command stboard for stm32mp25 boards

2024-01-15 Thread Patrick Delaunay 
Activate the command stboard for stm32mp25 STMicroelectronics boards,
add the default used OTP identifier and the associated board identifier:
- stm32mp25xx-ev1 = MB1936
- stm32mp25xx-dk = MB1605

Signed-off-by: Patrick Delaunay 
---

Changes in v2:
- fix CONFIG name with 'x': TARGET_ST_STM32MP15x TARGET_ST_STM32MP13x

 arch/arm/mach-stm32mp/include/mach/stm32.h | 1 +
 board/st/common/Kconfig| 2 +-
 board/st/common/cmd_stboard.c  | 2 ++
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h 
b/arch/arm/mach-stm32mp/include/mach/stm32.h
index 45c929aa605d..726c390977e3 100644
--- a/arch/arm/mach-stm32mp/include/mach/stm32.h
+++ b/arch/arm/mach-stm32mp/include/mach/stm32.h
@@ -198,6 +198,7 @@ enum forced_boot_mode {
 #define BSEC_OTP_SERIAL5
 #define BSEC_OTP_RPN   9
 #define BSEC_OTP_PKG   122
+#define BSEC_OTP_BOARD 246
 #define BSEC_OTP_MAC   247
 #endif
 
diff --git a/board/st/common/Kconfig b/board/st/common/Kconfig
index c1c254d07354..f40d1a78ca36 100644
--- a/board/st/common/Kconfig
+++ b/board/st/common/Kconfig
@@ -1,7 +1,7 @@
 config CMD_STBOARD
bool "stboard - command for OTP board information"
depends on ARCH_STM32MP
-   default y if TARGET_ST_STM32MP15x || TARGET_ST_STM32MP13x
+   default y if TARGET_ST_STM32MP25X || TARGET_ST_STM32MP15x || 
TARGET_ST_STM32MP13x
help
  This compile the stboard command to
  read and write the board in the OTP.
diff --git a/board/st/common/cmd_stboard.c b/board/st/common/cmd_stboard.c
index 853ab78bbf16..cb103e69b369 100644
--- a/board/st/common/cmd_stboard.c
+++ b/board/st/common/cmd_stboard.c
@@ -49,7 +49,9 @@ static bool check_stboard(u16 board)
0x1298,
0x1341,
0x1497,
+   0x1605, /* stm32mp25xx-dk */
0x1635,
+   0x1936, /* stm32mp25xx-ev1 */
};
 
for (i = 0; i < ARRAY_SIZE(st_board_id); i++)
-- 
2.25.1